From 7607ab2c842f2b998c7fa73aab59123860d93ae4 Mon Sep 17 00:00:00 2001
From: Pierre Tachoire <pierre@lightpanda.io>
Date: Thu, 20 Mar 2025 09:26:42 +0100
Subject: [PATCH] cdp: target: implement detach from target

---
 src/cdp/target.zig | 39 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/src/cdp/target.zig b/src/cdp/target.zig
index 5469f7db..35bac169 100644
--- a/src/cdp/target.zig
+++ b/src/cdp/target.zig
@@ -305,8 +305,18 @@ fn sendMessageToTarget(cmd: anytype) !void {
     }, .{});
 }
 
-// noop
 fn detachFromTarget(cmd: anytype) !void {
+    // TODO check if sessionId/targetId match.
+    // const params = (try cmd.params(struct {
+    //     sessionId: ?[]const u8,
+    //     targetId: ?[]const u8,
+    // })) orelse return error.InvalidParams;
+
+    if (cmd.browser_context) |bc| {
+        bc.session_id = null;
+        // TODO should we send a Target.detachedFromTarget event?
+    }
+
     return cmd.sendResult(null, .{});
 }
 
@@ -329,7 +339,11 @@ fn setAutoAttach(cmd: anytype) !void {
     try cmd.sendResult(null, .{});
 
     if (cmd.cdp.target_auto_attach == false) {
-        // TODO: detach from all currently attached targets.
+        // detach from all currently attached targets.
+        if (cmd.browser_context) |bc| {
+            bc.session_id = null;
+            // TODO should we send a Target.detachedFromTarget event?
+        }
         return;
     }
 
@@ -643,3 +657,24 @@ test "cdp.target: issue#474: attach to just created target" {
         try ctx.expectSentResult(.{ .sessionId = session_id }, .{ .id = 11 });
     }
 }
+
+test "cdp.target: detachFromTarget" {
+    var ctx = testing.context();
+    defer ctx.deinit();
+    const bc = try ctx.loadBrowserContext(.{ .id = "BID-9" });
+    {
+        try ctx.processMessage(.{ .id = 10, .method = "Target.createTarget", .params = .{ .browserContextId = "BID-9" } });
+        try testing.expectEqual(true, bc.target_id != null);
+        try ctx.expectSentResult(.{ .targetId = bc.target_id.? }, .{ .id = 10 });
+
+        try ctx.processMessage(.{ .id = 11, .method = "Target.attachToTarget", .params = .{ .targetId = bc.target_id.? } });
+        try ctx.expectSentResult(.{ .sessionId = bc.session_id.? }, .{ .id = 11 });
+
+        try ctx.processMessage(.{ .id = 12, .method = "Target.detachFromTarget", .params = .{ .targetId = bc.target_id.? } });
+        try testing.expectEqual(null, bc.session_id);
+        try ctx.expectSentResult(null, .{ .id = 12 });
+
+        try ctx.processMessage(.{ .id = 13, .method = "Target.attachToTarget", .params = .{ .targetId = bc.target_id.? } });
+        try ctx.expectSentResult(.{ .sessionId = bc.session_id.? }, .{ .id = 13 });
+    }
+}