public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Reduce info logs of HTTP event

Browse Source 
In normal cases, only log a single info event HTTP request. In an error case or
when log-level=debug, more may be logged.
This commit is contained in:
Karl Seguin
2025-05-28 11:15:57 +08:00
parent d7a3e2f450
commit 79d1425530
2 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/browser/page.zig
View File

@@ -181,7 +181,7 @@ pub const Page = struct {
const session = self.session; const session = self.session;
const notification = session.browser.notification; const notification = session.browser.notification;
log.info(.page, "navigate", .{ .url = request_url, .reason = opts.reason }); log.debug(.page, "navigate", .{ .url = request_url, .reason = opts.reason });
// if the url is about:blank, nothing to do. // if the url is about:blank, nothing to do.
if (std.mem.eql(u8, "about:blank", request_url.raw)) { if (std.mem.eql(u8, "about:blank", request_url.raw)) {
@@ -229,7 +229,12 @@ pub const Page = struct {
break :blk Mime.sniff(try response.peek()); break :blk Mime.sniff(try response.peek());
} orelse .unknown; } orelse .unknown;
log.info(.page, "navigation header", .{ .status = header.status, .content_type = content_type, .charset = mime.charset }); log.info(.page, "navigation", .{
.status = header.status,
.content_type = content_type,
.charset = mime.charset,
.url = request_url,
});
if (mime.isHTML()) { if (mime.isHTML()) {
self.raw_data = null; self.raw_data = null;
@@ -248,7 +253,7 @@ pub const Page = struct {
.url = &self.url, .url = &self.url,
.timestamp = timestamp(), .timestamp = timestamp(),
}); });
log.info(.page, "navigation complete", .{}); log.debug(.page, "navigation complete", .{});
} }
// https://html.spec.whatwg.org/#read-html // https://html.spec.whatwg.org/#read-html
@@ -439,8 +444,8 @@ pub const Page = struct {
var origin_url = &self.url; var origin_url = &self.url;
const url = try origin_url.resolve(arena, res_src); const url = try origin_url.resolve(arena, res_src);
log.info(.page, "fetching script", .{ .url = url }); log.debug(.page, "fetching script", .{ .url = url });
errdefer |err| log.err(.page, "fetch error", .{ .err = err }); errdefer |err| log.err(.page, "fetch error", .{ .err = err, .url = url });
var request = try self.newHTTPRequest(.GET, &url, .{ var request = try self.newHTTPRequest(.GET, &url, .{
.origin_uri = &origin_url.uri, .origin_uri = &origin_url.uri,
@@ -468,7 +473,11 @@ pub const Page = struct {
return null; return null;
} }
log.info(.page, "fetch complete", .{ .status = header.status, .content_length = arr.items.len }); log.info(.page, "fetch complete", .{
.url = url,
.status = header.status,
.content_length = arr.items.len,
});
return arr.items; return arr.items;
} }

9
src/browser/xhr/xhr.zig
View File

@@ -412,7 +412,7 @@ pub const XMLHttpRequest = struct {
if (self.state != .opened) return DOMError.InvalidState; if (self.state != .opened) return DOMError.InvalidState;
if (self.send_flag) return DOMError.InvalidState; if (self.send_flag) return DOMError.InvalidState;
log.info(.xhr, "request", .{ .method = self.method, .url = self.url }); log.debug(.xhr, "request", .{ .method = self.method, .url = self.url });
self.send_flag = true; self.send_flag = true;
@@ -459,7 +459,7 @@ pub const XMLHttpRequest = struct {
if (progress.first) { if (progress.first) {
const header = progress.header; const header = progress.header;
log.info(.xhr, "request header", .{ .status = header.status }); log.debug(.xhr, "request header", .{ .status = header.status });
for (header.headers.items) |hdr| { for (header.headers.items) |hdr| {
try self.response_headers.append(hdr.name, hdr.value); try self.response_headers.append(hdr.name, hdr.value);
} }
@@ -505,7 +505,10 @@ pub const XMLHttpRequest = struct {
return; return;
} }
log.info(.xhr, "request complete", .{}); log.info(.xhr, "request complete", .{
.url = self.url,
.status = progress.header.status,
});
self.state = .done; self.state = .done;
self.send_flag = false; self.send_flag = false;