public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-31 01:28:55 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

always close file on serveFromCache

Browse Source
This commit is contained in:
Muki Kiboigo
2026-03-30 11:33:19 -07:00
parent d06dd1208f
commit 7aa0360788
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
lp-net-cache/6ba046812fd9e6b6c7e484ec946c6f2dcc1e6022693e854809c72179a7a486b7.cache Normal file
View File

Binary file not shown.

9
src/browser/HttpClient.zig
View File

@@ -316,6 +316,10 @@ pub fn request(self: *Client, req: Request) !void {
fn serveFromCache(req: Request, cached: *const CachedResponse) !void { fn serveFromCache(req: Request, cached: *const CachedResponse) !void {
const response = Response.fromCached(req.ctx, cached); const response = Response.fromCached(req.ctx, cached);
defer switch (cached.data) {
.buffer => |_| {},
.file => |f| f.file.close(),
};
if (req.start_callback) |cb| { if (req.start_callback) |cb| {
try cb(response); try cb(response);
@@ -323,10 +327,6 @@ fn serveFromCache(req: Request, cached: *const CachedResponse) !void {
const proceed = try req.header_callback(response); const proceed = try req.header_callback(response);
if (!proceed) { if (!proceed) {
switch (cached.data) {
.buffer => |_| {},
.file => |f| f.file.close(),
}
req.error_callback(req.ctx, error.Abort); req.error_callback(req.ctx, error.Abort);
return; return;
} }
@@ -339,7 +339,6 @@ fn serveFromCache(req: Request, cached: *const CachedResponse) !void {
}, },
.file => |f| { .file => |f| {
const file = f.file; const file = f.file;
defer file.close();
var buf: [1024]u8 = undefined; var buf: [1024]u8 = undefined;
var file_reader = file.reader(&buf); var file_reader = file.reader(&buf);