Merge pull request #958 from lightpanda-io/http_request_done_notification

Emits a http_request_done internal notification.
This commit is contained in:
Karl Seguin
2025-08-21 09:23:41 +08:00
committed by GitHub
4 changed files with 60 additions and 2 deletions

View File

@@ -376,8 +376,14 @@ fn perform(self: *Client, timeout_ms: c_int) !void {
// transfer isn't valid at this point, don't use it.
log.err(.http, "done_callback", .{ .err = err });
self.requestFailed(transfer, err);
continue;
};
// self.requestComplete(transfer);
if (transfer.client.notification) |notification| {
notification.dispatch(.http_request_done, &.{
.transfer = transfer,
});
}
} else |err| {
self.requestFailed(transfer, err);
}
@@ -551,11 +557,15 @@ pub const Transfer = struct {
uri: std.Uri, // used for setting/getting the cookie
ctx: *anyopaque, // copied from req.ctx to make it easier for callback handlers
client: *Client,
_notified_fail: bool = false,
// total bytes received in the response, including the response status line,
// the headers, and the [encoded] body.
bytes_received: usize = 0,
// We'll store the response header here
response_header: ?ResponseHeader = null,
_notified_fail: bool = false,
_handle: ?*Handle = null,
_redirecting: bool = false,
@@ -715,9 +725,11 @@ pub const Transfer = struct {
.url = url,
.status = status,
};
transfer.bytes_received = buf_len;
return buf_len;
}
transfer.bytes_received += buf_len;
if (buf_len == 2) {
if (getResponseHeader(easy, "content-type", 0)) |ct| {
var hdr = &transfer.response_header.?;
@@ -767,6 +779,7 @@ pub const Transfer = struct {
return chunk_len;
}
transfer.bytes_received += chunk_len;
transfer.req.data_callback(transfer, buffer[0..chunk_len]) catch |err| {
log.err(.http, "data_callback", .{ .err = err, .req = transfer });
return c.CURL_WRITEFUNC_ERROR;