public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-28 15:40:04 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

MCP/CDP: unify node registration

Browse Source 
This fixes a bug in MCP where interactive elements were not assigned
a backendNodeId, preventing agents from clicking or filling them. Also
extracts link collection to a shared browser module.
This commit is contained in:
Adrià Arrufat
2026-03-26 23:49:42 +09:00
parent a0dd14aaad
commit 7e778a17d6
5 changed files with 82 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/mcp/tools.zig
View File

@@ -203,23 +203,12 @@ const ToolStreamingText = struct {
log.err(.mcp, "markdown dump failed", .{ .err = err });
},
.links => {
if (Selector.querySelectorAll(self.page.document.asNode(), "a[href]", self.page)) |list| {
defer list.deinit(self.page._session);
if (lp.links.collectLinks(self.page.call_arena, self.page.document.asNode(), self.page)) |links| {
var first = true;
for (list._nodes) |node| {
if (node.is(Element.Html.Anchor)) |anchor| {
const href = anchor.getHref(self.page) catch |err| {
log.err(.mcp, "resolve href failed", .{ .err = err });
continue;
};
if (href.len > 0) {
if (!first) try w.writeByte('\n');
try w.writeAll(href);
first = false;
}
}
for (links) |href| {
if (!first) try w.writeByte('\n');
try w.writeAll(href);
first = false;
}
} else |err| {
log.err(.mcp, "query links failed", .{ .err = err });
@@ -417,6 +406,12 @@ fn handleInteractiveElements(server: *Server, arena: std.mem.Allocator, id: std.
log.err(.mcp, "elements collection failed", .{ .err = err });
return server.sendError(id, .InternalError, "Failed to collect interactive elements");
};
lp.interactive.registerNodes(elements, &server.node_registry) catch |err| {
log.err(.mcp, "node registration failed", .{ .err = err });
return server.sendError(id, .InternalError, "Failed to register element nodes");
};
var aw: std.Io.Writer.Allocating = .init(arena);
try std.json.Stringify.value(elements, .{}, &aw.writer);