From e65667963fe1832dd3eb84661df91606146cf1ec Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Sat, 28 Feb 2026 12:48:45 +0800 Subject: [PATCH] Correctly JSON encode URL I think this code comes from some serialization tweak from when everything was an std.Uri and by switch to [:0]const u8 everywhere not only was the tweak unecessary, it was also wrong - possibly resulting in the generation of invalid JSON. --- src/cdp/domains/network.zig | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/src/cdp/domains/network.zig b/src/cdp/domains/network.zig index bd175978..bad29b2d 100644 --- a/src/cdp/domains/network.zig +++ b/src/cdp/domains/network.zig @@ -300,29 +300,19 @@ pub const TransferAsRequestWriter = struct { self._jsonStringify(jws) catch return error.WriteFailed; } fn _jsonStringify(self: *const TransferAsRequestWriter, jws: anytype) !void { - const writer = jws.writer; const transfer = self.transfer; try jws.beginObject(); { try jws.objectField("url"); - try jws.beginWriteRaw(); - try writer.writeByte('\"'); - // #ZIGDOM shouldn't include the hash? - try writer.writeAll(transfer.url); - try writer.writeByte('\"'); - jws.endWriteRaw(); + try jws.write(transfer.url); } { const frag = URL.getHash(transfer.url); if (frag.len > 0) { try jws.objectField("urlFragment"); - try jws.beginWriteRaw(); - try writer.writeAll("\"#"); - try writer.writeAll(frag); - try writer.writeByte('\"'); - jws.endWriteRaw(); + try jws.write(frag); } } @@ -366,18 +356,12 @@ const TransferAsResponseWriter = struct { } fn _jsonStringify(self: *const TransferAsResponseWriter, jws: anytype) !void { - const writer = jws.writer; const transfer = self.transfer; try jws.beginObject(); { try jws.objectField("url"); - try jws.beginWriteRaw(); - try writer.writeByte('\"'); - // #ZIGDOM shouldn't include the hash? - try writer.writeAll(transfer.url); - try writer.writeByte('\"'); - jws.endWriteRaw(); + try jws.write(transfer.url); } if (transfer.response_header) |*rh| {