public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Ensure extra_socket can't happen when exit_when_done == true

Browse Source 
exit_when_done is pretty much a sneaky way to get CDP knowledge into the page.
exit_when_done == true means "this isn't a CDP session".

extra_socket is another sneaky weay to get CDP knowledge into the page. When
we get an `extra_socket` message it means "Return control to the CDP server".

Therefore it should be impossible to get an `extra_socket` message (return to
CDP) when `exit_when_done == true` (this isn't a CDP session).
This commit is contained in:
Karl Seguin
2025-09-19 16:59:36 +08:00
parent 8a2efde365
commit 853b7f84ef
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/browser/page.zig
View File

@@ -312,6 +312,12 @@ pub const Page = struct {
// mode with an extra socket. Either way, we're waiting // mode with an extra socket. Either way, we're waiting
// for http traffic // for http traffic
if (try http_client.tick(ms_remaining) == .extra_socket) { if (try http_client.tick(ms_remaining) == .extra_socket) {
// exit_when_done is explicitly set when there isn't
// an extra socket, so it should not be possibl to
// get an extra_socket message when exit_when_done
// is true.
std.debug.assert(exit_when_done == false);
// data on a socket we aren't handling, return to caller // data on a socket we aren't handling, return to caller
return .extra_socket; return .extra_socket;
} }