public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-30 15:41:48 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

xhr: add a setOnload due to a setter issue

Browse Source 
see https://lightpanda.slack.com/archives/C05TRU6RBM1/p1706708213838989
This commit is contained in:
Pierre Tachoire
2024-01-31 14:41:23 +01:00
parent c2bc48ba0f
commit 89409a4847
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/xhr/xhr.zig
View File

@@ -45,6 +45,11 @@ pub const XMLHttpRequestEventTarget = struct {
pub fn set_onabort(self: *XMLHttpRequestEventTarget, handler: Callback) void { pub fn set_onabort(self: *XMLHttpRequestEventTarget, handler: Callback) void {
self.onabort_cbk = handler; self.onabort_cbk = handler;
} }
// TODO remove-me, test func du to an issue w/ the setter.
// see https://lightpanda.slack.com/archives/C05TRU6RBM1/p1706708213838989
pub fn _setOnload(self: *XMLHttpRequestEventTarget, handler: Callback) void {
self.set_onload(handler);
}
pub fn set_onload(self: *XMLHttpRequestEventTarget, handler: Callback) void { pub fn set_onload(self: *XMLHttpRequestEventTarget, handler: Callback) void {
self.onload_cbk = handler; self.onload_cbk = handler;
} }
@@ -212,7 +217,12 @@ pub fn testExecFn(
var send = [_]Case{ var send = [_]Case{
.{ .src = "var nb = 0; function cbk(event) { nb ++; }", .ex = "undefined" }, .{ .src = "var nb = 0; function cbk(event) { nb ++; }", .ex = "undefined" },
.{ .src = "const req = new XMLHttpRequest()", .ex = "undefined" }, .{ .src = "const req = new XMLHttpRequest()", .ex = "undefined" },
.{ .src = "req.onload = cbk", .ex = "function cbk(event) { nb ++; }" },
// TODO remove-me, test func du to an issue w/ the setter.
// see https://lightpanda.slack.com/archives/C05TRU6RBM1/p1706708213838989
.{ .src = "req.setOnload(cbk)", .ex = "undefined" },
// .{ .src = "req.onload = cbk", .ex = "function cbk(event) { nb ++; }" },
.{ .src = "req.open('GET', 'https://w3.org')", .ex = "undefined" }, .{ .src = "req.open('GET', 'https://w3.org')", .ex = "undefined" },
.{ .src = "req.send(); nb", .ex = "0" }, .{ .src = "req.send(); nb", .ex = "0" },
// Each case executed waits for all loop callaback calls. // Each case executed waits for all loop callaback calls.