public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #865 from lightpanda-io/document_domain

Browse Source 
Fix document.domain
This commit is contained in:
Karl Seguin
2025-07-10 21:46:15 +08:00
committed by GitHub
parent bfc01d957b 34b3c3982b
commit 8c2c1e534c
2 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/browser/html/document.zig
View File

@@ -42,8 +42,12 @@ pub const HTMLDocument = struct {
// JS funcs // JS funcs
// -------- // --------
pub fn get_domain(self: *parser.DocumentHTML) ![]const u8 { pub fn get_domain(self: *parser.DocumentHTML, page: *Page) ![]const u8 {
return try parser.documentHTMLGetDomain(self); // libdom's document_html get_domain always returns null, this is
// the way MDN recommends getting the domain anyways, since document.domain
// is deprecated.
const location = try parser.documentHTMLGetLocation(Location, self) orelse return "";
return location.get_host(page);
} }
pub fn set_domain(_: *parser.DocumentHTML, _: []const u8) ![]const u8 { pub fn set_domain(_: *parser.DocumentHTML, _: []const u8) ![]const u8 {
@@ -307,7 +311,7 @@ test "Browser.HTML.Document" {
}, .{}); }, .{});
try runner.testCases(&.{ try runner.testCases(&.{
.{ "document.domain", "" }, .{ "document.domain", "lightpanda.io" },
.{ "document.referrer", "" }, .{ "document.referrer", "" },
.{ "document.title", "" }, .{ "document.title", "" },
.{ "document.body.localName", "body" }, .{ "document.body.localName", "body" },

8
src/browser/netsurf.zig
View File

@@ -2384,14 +2384,6 @@ pub inline fn documentHTMLSetBody(doc_html: *DocumentHTML, elt: ?*ElementHTML) !
try DOMErr(err); try DOMErr(err);
} }
pub inline fn documentHTMLGetDomain(doc: *DocumentHTML) ![]const u8 {
var s: ?*String = undefined;
const err = documentHTMLVtable(doc).get_domain.?(doc, &s);
try DOMErr(err);
if (s == null) return "";
return strToData(s.?);
}
pub inline fn documentHTMLGetReferrer(doc: *DocumentHTML) ![]const u8 { pub inline fn documentHTMLGetReferrer(doc: *DocumentHTML) ![]const u8 {
var s: ?*String = undefined; var s: ?*String = undefined;
const err = documentHTMLVtable(doc).get_referrer.?(doc, &s); const err = documentHTMLVtable(doc).get_referrer.?(doc, &s);