From 926892be018a3e78ef77723ff2ac876a6a153ce0 Mon Sep 17 00:00:00 2001 From: Halil Durak Date: Mon, 19 Jan 2026 10:57:48 +0300 Subject: [PATCH] add `not_implemented` warnings --- src/browser/webapi/Element.zig | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/browser/webapi/Element.zig b/src/browser/webapi/Element.zig index a33d6cc5..0f7cb87f 100644 --- a/src/browser/webapi/Element.zig +++ b/src/browser/webapi/Element.zig @@ -468,7 +468,18 @@ pub fn getAttribute(self: *const Element, name: []const u8, page: *Page) !?[]con } /// For simplicity, the namespace is currently ignored and only the local name is used. -pub fn getAttributeNS(self: *const Element, _: ?[]const u8, local_name: []const u8, page: *Page) !?[]const u8 { +pub fn getAttributeNS( + self: *const Element, + maybe_namespace: ?[]const u8, + local_name: []const u8, + page: *Page, +) !?[]const u8 { + if (maybe_namespace) |namespace| { + if (!std.mem.eql(u8, namespace, "http://www.w3.org/1999/xhtml")) { + log.warn(.not_implemented, "Element.getAttributeNS", .{ .namespace = namespace }); + } + } + return self.getAttribute(local_name, page); } @@ -504,7 +515,19 @@ pub fn setAttribute(self: *Element, name: []const u8, value: []const u8, page: * _ = try attributes.put(name, value, self, page); } -pub fn setAttributeNS(self: *Element, _: ?[]const u8, qualified_name: []const u8, value: []const u8, page: *Page) !void { +pub fn setAttributeNS( + self: *Element, + maybe_namespace: ?[]const u8, + qualified_name: []const u8, + value: []const u8, + page: *Page, +) !void { + if (maybe_namespace) |namespace| { + if (!std.mem.eql(u8, namespace, "http://www.w3.org/1999/xhtml")) { + log.warn(.not_implemented, "Element.setAttributeNS", .{ .namespace = namespace }); + } + } + const local_name = if (std.mem.indexOfScalarPos(u8, qualified_name, 0, ':')) |idx| qualified_name[idx + 1 ..] else