public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-12-16 16:28:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

html_collection: update iterator values

Browse Source
This commit is contained in:
Pierre Tachoire
2024-01-15 12:03:59 +01:00
parent f59f36422c
commit 93db41ff10
1 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/dom/html_collection.zig
View File

@@ -469,12 +469,11 @@ pub const HTMLCollection = struct {
return null; return null;
} }
fn item_name(n: Union) !?[]const u8 { fn item_name(elt: *parser.Element) !?[]const u8 {
const elem = @as(*parser.Element, @ptrCast(n)); if (try parser.elementGetAttribute(elt, "id")) |v| {
if (try parser.elementGetAttribute(elem, "id")) |v| {
return v; return v;
} }
if (try parser.elementGetAttribute(elem, "name")) |v| { if (try parser.elementGetAttribute(elt, "name")) |v| {
return v; return v;
} }
@@ -486,16 +485,15 @@ pub const HTMLCollection = struct {
var i: u32 = 0; var i: u32 = 0;
while (i < ln) { while (i < ln) {
defer i += 1; defer i += 1;
const v = try self._item(i);
// TODO k must be deinit
const k = try std.fmt.allocPrint(alloc, "{d}", .{i}); const k = try std.fmt.allocPrint(alloc, "{d}", .{i});
try js_obj.set(k, v); try self.array_like_keys.append(alloc, k);
self.array_like_keys.append(alloc, k); const node = try self.item(i) orelse unreachable;
const e = @as(*parser.Element, @ptrCast(node));
try js_obj.set(k, e);
if (try item_name(v)) |name| { if (try item_name(e)) |name| {
try js_obj.set(name, v); try js_obj.set(name, e);
} }
} }
} }
@@ -534,6 +532,10 @@ pub fn testExecFn(
// array like // array like
.{ .src = "getElementsByTagNameAll[0].localName", .ex = "html" }, .{ .src = "getElementsByTagNameAll[0].localName", .ex = "html" },
.{ .src = "getElementsByTagNameAll[7].localName", .ex = "p" },
.{ .src = "getElementsByTagNameAll[8]", .ex = "undefined" },
.{ .src = "getElementsByTagNameAll['para-empty-child'].localName", .ex = "span" },
.{ .src = "getElementsByTagNameAll['foo']", .ex = "undefined" },
.{ .src = "document.getElementById('content').getElementsByTagName('*').length", .ex = "4" }, .{ .src = "document.getElementById('content').getElementsByTagName('*').length", .ex = "4" },
.{ .src = "document.getElementById('content').getElementsByTagName('p').length", .ex = "2" }, .{ .src = "document.getElementById('content').getElementsByTagName('p').length", .ex = "2" },