public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Define the index handler on the instance, not the prototype.

Browse Source 
While it sorta works if done on the prototype, it's incorrect as these are no
longer "own" properties (which some WPT tests care about). NamedIndexes were
already correctly defined on the instance.
This commit is contained in:
Karl Seguin
2026-01-09 10:31:01 +08:00
parent 78ebd5faf8
commit 967a2030e6
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/browser/js/Snapshot.zig
View File

@@ -387,6 +387,8 @@ fn generateConstructor(comptime JsApi: type, isolate: v8.Isolate) v8.FunctionTem
// Attaches JsApi members to the prototype template (normal case) // Attaches JsApi members to the prototype template (normal case)
fn attachClass(comptime JsApi: type, isolate: v8.Isolate, template: v8.FunctionTemplate) void { fn attachClass(comptime JsApi: type, isolate: v8.Isolate, template: v8.FunctionTemplate) void {
const target = template.getPrototypeTemplate(); const target = template.getPrototypeTemplate();
const instance = template.getInstanceTemplate();
const declarations = @typeInfo(JsApi).@"struct".decls; const declarations = @typeInfo(JsApi).@"struct".decls;
inline for (declarations) |d| { inline for (declarations) |d| {
const name: [:0]const u8 = d.name; const name: [:0]const u8 = d.name;
@@ -422,9 +424,9 @@ fn attachClass(comptime JsApi: type, isolate: v8.Isolate, template: v8.FunctionT
const configuration = v8.IndexedPropertyHandlerConfiguration{ const configuration = v8.IndexedPropertyHandlerConfiguration{
.getter = value.getter, .getter = value.getter,
}; };
target.setIndexedProperty(configuration, null); instance.setIndexedProperty(configuration, null);
}, },
bridge.NamedIndexed => template.getInstanceTemplate().setNamedProperty(.{ bridge.NamedIndexed => instance.setNamedProperty(.{
.getter = value.getter, .getter = value.getter,
.setter = value.setter, .setter = value.setter,
.deleter = value.deleter, .deleter = value.deleter,
@@ -456,15 +458,13 @@ fn attachClass(comptime JsApi: type, isolate: v8.Isolate, template: v8.FunctionT
} }
if (@hasDecl(JsApi.Meta, "htmldda")) { if (@hasDecl(JsApi.Meta, "htmldda")) {
const instance_template = template.getInstanceTemplate(); instance.markAsUndetectable();
instance_template.markAsUndetectable(); instance.setCallAsFunctionHandler(JsApi.Meta.callable.func);
instance_template.setCallAsFunctionHandler(JsApi.Meta.callable.func);
} }
if (@hasDecl(JsApi.Meta, "name")) { if (@hasDecl(JsApi.Meta, "name")) {
const js_name = v8.Symbol.getToStringTag(isolate).toName(); const js_name = v8.Symbol.getToStringTag(isolate).toName();
const instance_template = template.getInstanceTemplate(); instance.set(js_name, v8.String.initUtf8(isolate, JsApi.Meta.name), v8.PropertyAttribute.ReadOnly + v8.PropertyAttribute.DontDelete);
instance_template.set(js_name, v8.String.initUtf8(isolate, JsApi.Meta.name), v8.PropertyAttribute.ReadOnly + v8.PropertyAttribute.DontDelete);
} }
} }