From 98b041e84ad4233d89dc582f785caf5f73e9f29c Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Thu, 17 Jul 2025 10:36:20 +0800 Subject: [PATCH] requestChildNode cannot have a depth of 0 --- src/cdp/Node.zig | 4 ++-- src/cdp/domains/dom.zig | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/cdp/Node.zig b/src/cdp/Node.zig index 2e987c7e..a0d85dcf 100644 --- a/src/cdp/Node.zig +++ b/src/cdp/Node.zig @@ -213,7 +213,7 @@ pub const Writer = struct { pub fn jsonStringify(self: *const Writer, w: anytype) !void { if (self.exclude_root) { - _ = self.writeChildren(self.root, 0, w) catch |err| { + _ = self.writeChildren(self.root, 1, w) catch |err| { log.err(.cdp, "node writeChildren", .{ .err = err }); return error.OutOfMemory; }; @@ -467,7 +467,7 @@ test "cdp Node: Writer" { const node = registry.lookup_by_id.get(1).?; const json = try std.json.stringifyAlloc(testing.allocator, Writer{ .root = node, - .depth = 0, + .depth = 1, .exclude_root = false, .registry = ®istry, }, .{}); diff --git a/src/cdp/domains/dom.zig b/src/cdp/domains/dom.zig index a352328d..a43d1eaf 100644 --- a/src/cdp/domains/dom.zig +++ b/src/cdp/domains/dom.zig @@ -442,6 +442,7 @@ fn requestChildNodes(cmd: anytype) !void { pierce: bool = false, })) orelse return error.InvalidParams; + if (params.depth == 0) return error.InvalidParams; const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded; const session_id = bc.session_id orelse return error.SessionIdNotLoaded; const node = bc.node_registry.lookup_by_id.get(params.nodeId) orelse {