public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

handle null anchor or focus nodes in Selection

Browse Source
This commit is contained in:
Muki Kiboigo
2026-01-16 00:49:30 -08:00
parent f56d3bd193
commit 992a8e8774
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/browser/webapi/Selection.zig
View File

@@ -37,7 +37,9 @@ pub const init: Selection = .{};
fn isInTree(self: *const Selection) bool { fn isInTree(self: *const Selection) bool {
if (self._range == null) return false; if (self._range == null) return false;
return self.getAnchorNode().?.isConnected() and self.getFocusNode().?.isConnected(); const anchor_node = self.getAnchorNode() orelse return false;
const focus_node = self.getFocusNode() orelse return false;
return anchor_node.isConnected() and focus_node.isConnected();
} }
pub fn getAnchorNode(self: *const Selection) ?*Node { pub fn getAnchorNode(self: *const Selection) ?*Node {
@@ -53,7 +55,9 @@ pub fn getAnchorNode(self: *const Selection) ?*Node {
pub fn getAnchorOffset(self: *const Selection) u32 { pub fn getAnchorOffset(self: *const Selection) u32 {
const range = self._range orelse return 0; const range = self._range orelse return 0;
if (!self.getAnchorNode().?.isConnected()) return 0;
const anchor_node = self.getAnchorNode() orelse return 0;
if (!anchor_node.isConnected()) return 0;
return switch (self._direction) { return switch (self._direction) {
.backward => range.asAbstractRange().getEndOffset(), .backward => range.asAbstractRange().getEndOffset(),
@@ -78,7 +82,8 @@ pub fn getFocusNode(self: *const Selection) ?*Node {
pub fn getFocusOffset(self: *const Selection) u32 { pub fn getFocusOffset(self: *const Selection) u32 {
const range = self._range orelse return 0; const range = self._range orelse return 0;
if (!self.getFocusNode().?.isConnected()) return 0; const focus_node = self.getFocusNode() orelse return 0;
if (!focus_node.isConnected()) return 0;
return switch (self._direction) { return switch (self._direction) {
.backward => range.asAbstractRange().getStartOffset(), .backward => range.asAbstractRange().getStartOffset(),