public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

We cannot have empty Zig structs mapping to JS instances

Browse Source 
An empty struct will share the same address as its sibling (1) which will cause
an collision in the identity map.

(1) - This depends on Zig's non-guaranteed layout, so the collision might not
be with its sibling, but rather some other [seemingly random] field.
This commit is contained in:
Karl Seguin
2025-06-25 14:58:09 +08:00
parent 2815f02382
commit 9c4088b24c
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/browser/crypto/crypto.zig
View File

@@ -21,6 +21,8 @@ const uuidv4 = @import("../../id.zig").uuidv4;
// https://w3c.github.io/webcrypto/#crypto-interface // https://w3c.github.io/webcrypto/#crypto-interface
pub const Crypto = struct { pub const Crypto = struct {
_not_empty: bool = true,
pub fn _getRandomValues(_: *const Crypto, into: RandomValues) !RandomValues { pub fn _getRandomValues(_: *const Crypto, into: RandomValues) !RandomValues {
const buf = into.asBuffer(); const buf = into.asBuffer();
if (buf.len > 65_536) { if (buf.len > 65_536) {

2
src/browser/css/css.zig
View File

@@ -29,6 +29,8 @@ pub const Interfaces = .{
// https://developer.mozilla.org/en-US/docs/Web/API/CSS // https://developer.mozilla.org/en-US/docs/Web/API/CSS
pub const Css = struct { pub const Css = struct {
_not_empty: bool = true,
pub fn _supports(_: *Css, _: []const u8, _: ?[]const u8) bool { pub fn _supports(_: *Css, _: []const u8, _: ?[]const u8) bool {
// TODO: Actually respond with which CSS features we support. // TODO: Actually respond with which CSS features we support.
return true; return true;