public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

cdp: set consistent target's default

Browse Source 
with about:blank for url and empty title.
This commit is contained in:
Pierre Tachoire
2026-03-03 17:24:08 +01:00
parent 56cc881ac0
commit 9ca5188e12
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/cdp/domains/target.zig
View File

@@ -81,7 +81,7 @@ fn getTargets(cmd: anytype) !void {
.targetInfos = [_]TargetInfo{.{ .targetInfos = [_]TargetInfo{.{
.targetId = target_id, .targetId = target_id,
.type = "page", .type = "page",
.title = bc.getTitle() orelse "about:blank", .title = bc.getTitle() orelse "",
.url = bc.getURL() orelse "about:blank", .url = bc.getURL() orelse "about:blank",
.attached = true, .attached = true,
.canAccessOpener = false, .canAccessOpener = false,
@@ -209,7 +209,7 @@ fn createTarget(cmd: anytype) !void {
.targetInfo = TargetInfo{ .targetInfo = TargetInfo{
.attached = false, .attached = false,
.targetId = target_id, .targetId = target_id,
.title = "about:blank", .title = "",
.browserContextId = bc.id, .browserContextId = bc.id,
.url = "about:blank", .url = "about:blank",
}, },
@@ -330,7 +330,7 @@ fn getTargetInfo(cmd: anytype) !void {
.targetInfo = TargetInfo{ .targetInfo = TargetInfo{
.targetId = target_id, .targetId = target_id,
.type = "page", .type = "page",
.title = bc.getTitle() orelse "about:blank", .title = bc.getTitle() orelse "",
.url = bc.getURL() orelse "about:blank", .url = bc.getURL() orelse "about:blank",
.attached = true, .attached = true,
.canAccessOpener = false, .canAccessOpener = false,
@@ -342,7 +342,7 @@ fn getTargetInfo(cmd: anytype) !void {
.targetInfo = TargetInfo{ .targetInfo = TargetInfo{
.targetId = "TID-STARTUP-B", .targetId = "TID-STARTUP-B",
.type = "browser", .type = "browser",
.title = "about:blank", .title = "",
.url = "about:blank", .url = "about:blank",
.attached = true, .attached = true,
.canAccessOpener = false, .canAccessOpener = false,
@@ -461,8 +461,8 @@ fn setAutoAttach(cmd: anytype) !void {
.targetInfo = TargetInfo{ .targetInfo = TargetInfo{
.type = "page", .type = "page",
.targetId = "TID-STARTUP-P", .targetId = "TID-STARTUP-P",
.title = "New Private Tab", .title = "",
.url = "chrome://newtab/", .url = "about:blank",
.browserContextId = "BID-STARTUP", .browserContextId = "BID-STARTUP",
}, },
}, .{}); }, .{});
@@ -482,8 +482,8 @@ fn doAttachtoTarget(cmd: anytype, target_id: []const u8) !void {
.sessionId = session_id, .sessionId = session_id,
.targetInfo = TargetInfo{ .targetInfo = TargetInfo{
.targetId = target_id, .targetId = target_id,
.title = bc.getTitle() orelse "about:blank", .title = bc.getTitle() orelse "",
.url = bc.getURL() orelse "chrome://newtab/", .url = bc.getURL() orelse "about:blank",
.browserContextId = bc.id, .browserContextId = bc.id,
}, },
}, .{ .session_id = bc.session_id }); }, .{ .session_id = bc.session_id });
@@ -588,7 +588,7 @@ test "cdp.target: createTarget" {
// should create a browser context // should create a browser context
const bc = ctx.cdp().browser_context.?; const bc = ctx.cdp().browser_context.?;
try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "about:blank", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{}); try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{});
} }
{ {
@@ -600,8 +600,8 @@ test "cdp.target: createTarget" {
// should create a browser context // should create a browser context
const bc = ctx.cdp().browser_context.?; const bc = ctx.cdp().browser_context.?;
try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "about:blank", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{}); try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{});
try ctx.expectSentEvent("Target.attachedToTarget", .{ .sessionId = bc.session_id.?, .targetInfo = .{ .url = "chrome://newtab/", .title = "about:blank", .attached = true, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{}); try ctx.expectSentEvent("Target.attachedToTarget", .{ .sessionId = bc.session_id.?, .targetInfo = .{ .url = "about:blank", .title = "", .attached = true, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{});
} }
var ctx = testing.context(); var ctx = testing.context();
@@ -616,7 +616,7 @@ test "cdp.target: createTarget" {
try ctx.processMessage(.{ .id = 10, .method = "Target.createTarget", .params = .{ .browserContextId = "BID-9" } }); try ctx.processMessage(.{ .id = 10, .method = "Target.createTarget", .params = .{ .browserContextId = "BID-9" } });
try testing.expectEqual(true, bc.target_id != null); try testing.expectEqual(true, bc.target_id != null);
try ctx.expectSentResult(.{ .targetId = bc.target_id.? }, .{ .id = 10 }); try ctx.expectSentResult(.{ .targetId = bc.target_id.? }, .{ .id = 10 });
try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "about:blank", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = "BID-9", .targetId = bc.target_id.? } }, .{}); try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = "BID-9", .targetId = bc.target_id.? } }, .{});
} }
} }
@@ -678,7 +678,7 @@ test "cdp.target: attachToTarget" {
try ctx.processMessage(.{ .id = 11, .method = "Target.attachToTarget", .params = .{ .targetId = "TID-000000000B" } }); try ctx.processMessage(.{ .id = 11, .method = "Target.attachToTarget", .params = .{ .targetId = "TID-000000000B" } });
const session_id = bc.session_id.?; const session_id = bc.session_id.?;
try ctx.expectSentResult(.{ .sessionId = session_id }, .{ .id = 11 }); try ctx.expectSentResult(.{ .sessionId = session_id }, .{ .id = 11 });
try ctx.expectSentEvent("Target.attachedToTarget", .{ .sessionId = session_id, .targetInfo = .{ .url = "chrome://newtab/", .title = "about:blank", .attached = true, .type = "page", .canAccessOpener = false, .browserContextId = "BID-9", .targetId = bc.target_id.? } }, .{}); try ctx.expectSentEvent("Target.attachedToTarget", .{ .sessionId = session_id, .targetInfo = .{ .url = "about:blank", .title = "", .attached = true, .type = "page", .canAccessOpener = false, .browserContextId = "BID-9", .targetId = bc.target_id.? } }, .{});
} }
} }
@@ -691,7 +691,7 @@ test "cdp.target: getTargetInfo" {
try ctx.expectSentResult(.{ try ctx.expectSentResult(.{
.targetInfo = .{ .targetInfo = .{
.type = "browser", .type = "browser",
.title = "about:blank", .title = "",
.url = "about:blank", .url = "about:blank",
.attached = true, .attached = true,
.canAccessOpener = false, .canAccessOpener = false,