From 9f3cb4349df47515f7eba986075e940ffdcc5c72 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Thu, 25 Dec 2025 09:08:01 +0800 Subject: [PATCH] more legacy test fixes --- src/browser/js/Function.zig | 2 +- src/browser/tests/legacy/html/location.html | 12 ++-- src/browser/tests/legacy/window/frames.html | 1 - src/browser/tests/legacy/window/window.html | 70 +++------------------ src/browser/tests/window/timers.html | 9 +++ src/browser/tests/window/window.html | 3 + src/browser/webapi/Window.zig | 62 +++++++++--------- src/main_legacy_test.zig | 1 - 8 files changed, 57 insertions(+), 103 deletions(-) diff --git a/src/browser/js/Function.zig b/src/browser/js/Function.zig index 4ab5be8a..e10f8f56 100644 --- a/src/browser/js/Function.zig +++ b/src/browser/js/Function.zig @@ -135,7 +135,7 @@ pub fn callWithThis(self: *const Function, comptime T: type, this: anytype, args .pointer => blk: { var values = try context.call_arena.alloc(v8.Value, args.len); for (args, 0..) |a, i| { - values[i] = try context.zigValueToJs(a); + values[i] = try context.zigValueToJs(a, .{}); } break :blk values; }, diff --git a/src/browser/tests/legacy/html/location.html b/src/browser/tests/legacy/html/location.html index 9987b9df..ad49b411 100644 --- a/src/browser/tests/legacy/html/location.html +++ b/src/browser/tests/legacy/html/location.html @@ -2,8 +2,8 @@ diff --git a/src/browser/tests/legacy/window/frames.html b/src/browser/tests/legacy/window/frames.html index fc4b7abc..669fbfde 100644 --- a/src/browser/tests/legacy/window/frames.html +++ b/src/browser/tests/legacy/window/frames.html @@ -9,5 +9,4 @@ diff --git a/src/browser/tests/legacy/window/window.html b/src/browser/tests/legacy/window/window.html index a8b5c041..7a2a7374 100644 --- a/src/browser/tests/legacy/window/window.html +++ b/src/browser/tests/legacy/window/window.html @@ -1,6 +1,7 @@ + - - @@ -81,46 +67,6 @@ }); - - + + + diff --git a/src/browser/tests/window/window.html b/src/browser/tests/window/window.html index 9cd74b37..b9d3d1d8 100644 --- a/src/browser/tests/window/window.html +++ b/src/browser/tests/window/window.html @@ -5,6 +5,9 @@ testing.expectEqual(window, globalThis); testing.expectEqual(window, self); testing.expectEqual(window, window.self); + + testing.expectEqual(1080, innerHeight); + testing.expectEqual(1920, innerWidth);