public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

add a shared boolean to GetResult to avoid deinit

Browse Source
This commit is contained in:
Pierre Tachoire
2025-10-17 18:02:21 +02:00
parent a5dfe8ab28
commit 9f4e3bf792
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/browser/ScriptManager.zig
View File

@@ -343,12 +343,14 @@ pub fn waitForModule(self: *ScriptManager, url: [:0]const u8) !GetResult {
defer self.sync_module_pool.destroy(sync); defer self.sync_module_pool.destroy(sync);
defer self.sync_modules.removeByPtr(entry.key_ptr); defer self.sync_modules.removeByPtr(entry.key_ptr);
return .{ return .{
.shared = false,
.buffer = sync.buffer, .buffer = sync.buffer,
.buffer_pool = &self.buffer_pool, .buffer_pool = &self.buffer_pool,
}; };
} }
return .{ return .{
.shared = true,
.buffer = sync.buffer, .buffer = sync.buffer,
.buffer_pool = &self.buffer_pool, .buffer_pool = &self.buffer_pool,
}; };
@@ -1012,6 +1014,7 @@ pub const AsyncModule = struct {
var self: *AsyncModule = @ptrCast(@alignCast(ctx)); var self: *AsyncModule = @ptrCast(@alignCast(ctx));
defer self.manager.async_module_pool.destroy(self); defer self.manager.async_module_pool.destroy(self);
self.cb(self.cb_data, .{ self.cb(self.cb_data, .{
.shared = false,
.buffer = self.buffer, .buffer = self.buffer,
.buffer_pool = &self.manager.buffer_pool, .buffer_pool = &self.manager.buffer_pool,
}); });
@@ -1035,8 +1038,13 @@ pub const AsyncModule = struct {
pub const GetResult = struct { pub const GetResult = struct {
buffer: std.ArrayListUnmanaged(u8), buffer: std.ArrayListUnmanaged(u8),
buffer_pool: *BufferPool, buffer_pool: *BufferPool,
shared: bool,
pub fn deinit(self: *GetResult) void { pub fn deinit(self: *GetResult) void {
// if the result is shared, don't deinit.
if (self.shared) {
return;
}
self.buffer_pool.release(self.buffer); self.buffer_pool.release(self.buffer);
} }