public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-30 15:41:48 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #476 from karlseguin/implicit_browser_context
Some checks failed
e2e-test / zig build release (push) Has been cancelled
Details
wpt / web platform tests (push) Has been cancelled
Details
zig-test / zig build dev (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
e2e-test / puppeteer-perf (push) Has been cancelled
Details
e2e-test / demo-scripts (push) Has been cancelled
Details
wpt / perf-fmt (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details

Browse Source 
Implicitly create BrowserContext on createTarget if one doesn't exist
This commit is contained in:
Pierre Tachoire
2025-03-18 09:21:50 +01:00
committed by GitHub
parent 4a4d9a9377 430779979e
commit 9fe10747ce
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/cdp/target.zig
View File

@@ -100,7 +100,11 @@ fn createTarget(cmd: anytype) !void {
// forTab: ?bool = null, // forTab: ?bool = null,
})) orelse return error.InvalidParams; })) orelse return error.InvalidParams;
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded; const bc = cmd.browser_context orelse cmd.createBrowserContext() catch |err| switch (err) {
error.AlreadyExists => unreachable,
else => return err,
};
if (bc.target_id != null) { if (bc.target_id != null) {
return error.TargetAlreadyLoaded; return error.TargetAlreadyLoaded;
} }
@@ -459,18 +463,19 @@ test "cdp.target: disposeBrowserContext" {
} }
test "cdp.target: createTarget" { test "cdp.target: createTarget" {
var ctx = testing.context();
defer ctx.deinit();
{ {
try testing.expectError(error.BrowserContextNotLoaded, ctx.processMessage(.{ var ctx = testing.context();
.id = 10, defer ctx.deinit();
.method = "Target.createTarget", try ctx.processMessage(.{ .id = 10, .method = "Target.createTarget", .params = .{ .url = "about/blank" } });
.params = struct {}{},
})); // should create a browser context
try ctx.expectSentError(-31998, "BrowserContextNotLoaded", .{ .id = 10 }); const bc = ctx.cdp().browser_context.?;
try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "about:blank", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{});
try ctx.expectSentEvent("Target.attachedToTarget", .{ .sessionId = bc.session_id.?, .targetInfo = .{ .url = "chrome://newtab/", .title = "about:blank", .attached = true, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{});
} }
var ctx = testing.context();
defer ctx.deinit();
const bc = try ctx.loadBrowserContext(.{ .id = "BID-9" }); const bc = try ctx.loadBrowserContext(.{ .id = "BID-9" });
{ {
try testing.expectError(error.UnknownBrowserContextId, ctx.processMessage(.{ .id = 10, .method = "Target.createTarget", .params = .{ .browserContextId = "BID-8" } })); try testing.expectError(error.UnknownBrowserContextId, ctx.processMessage(.{ .id = 10, .method = "Target.createTarget", .params = .{ .browserContextId = "BID-8" } }));