Merge pull request #1380 from lightpanda-io/static_accessor_fix

Fix static accessors
This commit is contained in:
Karl Seguin
2026-01-19 07:15:09 +08:00
committed by GitHub
3 changed files with 17 additions and 5 deletions

View File

@@ -720,11 +720,18 @@ pub const Accessor = struct {
defer caller.deinit();
const info = FunctionCallbackInfo{ .handle = handle.? };
if (comptime opts.static) {
caller.function(T, getter, info, .{
.as_typed_array = opts.as_typed_array,
.null_as_undefined = opts.null_as_undefined,
});
} else {
caller.method(T, getter, info, .{
.as_typed_array = opts.as_typed_array,
.null_as_undefined = opts.null_as_undefined,
});
}
}
}.wrap;
}

View File

@@ -37,6 +37,7 @@
}
</script>
<<<<<<< HEAD
<script id="microtask_access_to_list">
{
@@ -64,3 +65,7 @@
});
}
</script>
<script>
testing.expectEqual(['mark', 'measure'], PerformanceObserver.supportedEntryTypes);
</script>

View File

@@ -133,7 +133,7 @@ pub fn takeRecords(self: *PerformanceObserver, page: *Page) ![]*Performance.Entr
return records;
}
pub fn getSupportedEntryTypes(_: *const PerformanceObserver) []const []const u8 {
pub fn getSupportedEntryTypes() []const []const u8 {
return &.{ "mark", "measure" };
}