public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1489 from lightpanda-io/fix_profile_stringifiers

Browse Source 
Fix profiler stringifiers
This commit is contained in:
Pierre Tachoire
2026-02-08 10:34:17 +01:00
committed by GitHub
parent 8d43becb27 d6f801f764
commit abeda1935d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/browser/js/Context.zig
View File

@@ -1047,7 +1047,7 @@ pub fn stopCpuProfiler(self: *Context) ![]const u8 {
const title = self.isolate.initStringHandle("v8_cpu_profile");
const handle = v8.v8__CpuProfiler__StopProfiling(self.cpu_profiler.?, title) orelse return error.NoProfiles;
const string_handle = v8.v8__CpuProfile__Serialize(handle, self.isolate.handle) orelse return error.NoProfile;
return ls.local.jsStringToZig(string_handle, .{});
return (js.String{ .local = &ls.local, .handle = string_handle }).toSlice();
}
pub fn startHeapProfiler(self: *Context) void {
@@ -1079,7 +1079,7 @@ pub fn stopHeapProfiler(self: *Context) !struct { []const u8, []const u8 } {
const string_handle = v8.v8__AllocationProfile__Serialize(profile, self.isolate.handle);
v8.v8__HeapProfiler__StopSamplingHeapProfiler(self.heap_profiler.?);
v8.v8__AllocationProfile__Delete(profile);
break :blk try ls.local.jsStringToZig(string_handle, .{});
break :blk try (js.String{ .local = &ls.local, .handle = string_handle.? }).toSlice();
};
const snapshot = blk: {
@@ -1087,7 +1087,7 @@ pub fn stopHeapProfiler(self: *Context) !struct { []const u8, []const u8 } {
const string_handle = v8.v8__HeapSnapshot__Serialize(snapshot, self.isolate.handle);
v8.v8__HeapProfiler__StopTrackingHeapObjects(self.heap_profiler.?);
v8.v8__HeapSnapshot__Delete(snapshot);
break :blk try ls.local.jsStringToZig(string_handle, .{});
break :blk try (js.String{ .local = &ls.local, .handle = string_handle.? }).toSlice();
};
return .{ allocating, snapshot };