public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix: Properly handle node ownership when using appendChild and insertBefore

Browse Source
This commit is contained in:
Srikanth
2025-08-03 20:27:32 +05:30
parent 478f3a5308
commit b4014e8c24
1 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/browser/dom/node.zig
View File

@@ -198,6 +198,20 @@ pub const Node = struct {
// Methods // Methods
pub fn _appendChild(self: *parser.Node, child: *parser.Node) !Union { pub fn _appendChild(self: *parser.Node, child: *parser.Node) !Union {
const self_owner = try parser.nodeOwnerDocument(self);
const new_node_owner = try parser.nodeOwnerDocument(child);
if (new_node_owner == null or (new_node_owner.? != self_owner.?)) {
child.owner = self_owner;
// recursively set the owner for all children
var next: ?*parser.Node = child;
while (next) |n| {
next = try parser.nodeFirstChild(n) orelse break;
if (next) |child_next| {
child_next.owner = self_owner;
}
}
}
// TODO: DocumentFragment special case // TODO: DocumentFragment special case
const res = try parser.nodeAppendChild(self, child); const res = try parser.nodeAppendChild(self, child);
return try Node.toInterface(res); return try Node.toInterface(res);
@@ -290,6 +304,18 @@ pub const Node = struct {
} }
pub fn _insertBefore(self: *parser.Node, new_node: *parser.Node, ref_node_: ?*parser.Node) !Union { pub fn _insertBefore(self: *parser.Node, new_node: *parser.Node, ref_node_: ?*parser.Node) !Union {
const self_owner = try parser.nodeOwnerDocument(self);
const new_node_owner = try parser.nodeOwnerDocument(new_node);
if (new_node_owner == null or (new_node_owner.? != self_owner.?)) {
new_node.owner = self_owner;
var next: ?*parser.Node = new_node;
while (next) |n| {
next = try parser.nodeFirstChild(n) orelse break;
if (next) |child_next| {
child_next.owner = self_owner;
}
}
}
if (ref_node_) |ref_node| { if (ref_node_) |ref_node| {
return Node.toInterface(try parser.nodeInsertBefore(self, new_node, ref_node)); return Node.toInterface(try parser.nodeInsertBefore(self, new_node, ref_node));
} }