public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

refactor(cdp): always return base64-encoded Network.getResponseBody

Browse Source
This commit is contained in:
gilangjavier
2026-03-21 07:06:09 +07:00
parent b8f1622b52
commit b5b012bd5d
1 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/cdp/domains/network.zig
View File

@@ -210,14 +210,6 @@ fn getResponseBody(cmd: anytype) !void {
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded; const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
const buf = bc.captured_responses.getPtr(request_id) orelse return error.RequestNotFound; const buf = bc.captured_responses.getPtr(request_id) orelse return error.RequestNotFound;
if (std.unicode.utf8ValidateSlice(buf.items)) {
try cmd.sendResult(.{
.body = buf.items,
.base64Encoded = false,
}, .{});
return;
}
const encoded_len = std.base64.standard.Encoder.calcSize(buf.items.len); const encoded_len = std.base64.standard.Encoder.calcSize(buf.items.len);
const encoded = try cmd.arena.alloc(u8, encoded_len); const encoded = try cmd.arena.alloc(u8, encoded_len);
_ = std.base64.standard.Encoder.encode(encoded, buf.items); _ = std.base64.standard.Encoder.encode(encoded, buf.items);
@@ -536,7 +528,7 @@ test "cdp.Network: cookies" {
try ctx.expectSentResult(.{ .cookies = &[_]ResCookie{} }, .{ .id = 10 }); try ctx.expectSentResult(.{ .cookies = &[_]ResCookie{} }, .{ .id = 10 });
} }
test "cdp.Network.getResponseBody returns plain text for UTF-8 responses" { test "cdp.Network.getResponseBody base64-encodes UTF-8 responses" {
var ctx = testing.context(); var ctx = testing.context();
defer ctx.deinit(); defer ctx.deinit();
@@ -551,8 +543,8 @@ test "cdp.Network.getResponseBody returns plain text for UTF-8 responses" {
.params = .{ .requestId = "REQ-42" }, .params = .{ .requestId = "REQ-42" },
}); });
try ctx.expectSentResult(.{ try ctx.expectSentResult(.{
.body = "hello", .body = "aGVsbG8=",
.base64Encoded = false, .base64Encoded = true,
}, .{ .id = 11 }); }, .{ .id = 11 });
} }