public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

runtime: fix returning an empty array crash

Browse Source
This commit is contained in:
Pierre Tachoire
2025-08-08 17:26:39 +02:00
parent fbd40a6514
commit b785884cd8
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/runtime/js.zig
View File

@@ -3469,11 +3469,16 @@ fn simpleZigValueToJs(isolate: v8.Isolate, value: anytype, comptime fail: bool)
else => @compileError("Invalid TypeArray type: " ++ @typeName(value_type)), else => @compileError("Invalid TypeArray type: " ++ @typeName(value_type)),
}; };
const buffer_len = len * bits / 8; var array_buffer: v8.ArrayBuffer = undefined;
const backing_store = v8.BackingStore.init(isolate, buffer_len); if (len == 0) {
const data: [*]u8 = @alignCast(@ptrCast(backing_store.getData())); array_buffer = v8.ArrayBuffer.init(isolate, 0);
@memcpy(data[0..buffer_len], @as([]const u8, @ptrCast(values))[0..buffer_len]); } else {
const array_buffer = v8.ArrayBuffer.initWithBackingStore(isolate, &backing_store.toSharedPtr()); const buffer_len = len * bits / 8;
const backing_store = v8.BackingStore.init(isolate, buffer_len);
const data: [*]u8 = @alignCast(@ptrCast(backing_store.getData()));
@memcpy(data[0..buffer_len], @as([]const u8, @ptrCast(values))[0..buffer_len]);
array_buffer = v8.ArrayBuffer.initWithBackingStore(isolate, &backing_store.toSharedPtr());
}
switch (@typeInfo(value_type)) { switch (@typeInfo(value_type)) {
.int => |n| switch (n.signedness) { .int => |n| switch (n.signedness) {

5
src/runtime/test_primitive_types.zig
View File

@@ -118,6 +118,10 @@ const Primitives = struct {
} }
} }
pub fn _returnEmptyUint8(_: *const Primitives) Env.TypedArray(u8) {
return .{ .values = &.{} };
}
pub fn _returnUint8(_: *const Primitives) Env.TypedArray(u8) { pub fn _returnUint8(_: *const Primitives) Env.TypedArray(u8) {
return .{ .values = &.{ 10, 20, 250 } }; return .{ .values = &.{ 10, 20, 250 } };
} }
@@ -325,6 +329,7 @@ test "JS: primitive types" {
.{ "try { p.intu64(arr_i64) } catch(e) { e instanceof TypeError; }", "true" }, .{ "try { p.intu64(arr_i64) } catch(e) { e instanceof TypeError; }", "true" },
.{ "try { p.intu64(arr_u32) } catch(e) { e instanceof TypeError; }", "true" }, .{ "try { p.intu64(arr_u32) } catch(e) { e instanceof TypeError; }", "true" },
.{ "p.returnEmptyUint8()", "" },
.{ "p.returnUint8()", "10,20,250" }, .{ "p.returnUint8()", "10,20,250" },
.{ "p.returnInt8()", "10,-20,-120" }, .{ "p.returnInt8()", "10,-20,-120" },
.{ "p.returnUint16()", "10,200,2050" }, .{ "p.returnUint16()", "10,200,2050" },