public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-28 15:40:04 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #1987 from lightpanda-io/conn-close

Browse Source 
handle Connection: close without TLS close_notify
This commit is contained in:
Karl Seguin
2026-03-25 16:11:42 +08:00
committed by GitHub
parent 3a0cead03a 92ce6a916a
commit b81b41cbf0
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/browser/HttpClient.zig
View File

@@ -848,14 +848,28 @@ fn processMessages(self: *Client) !bool {
} }
} }
// When the server sends "Connection: close" and closes the TLS
// connection without a close_notify alert, BoringSSL reports
// RecvError. If we already received valid HTTP headers, this is
// a normal end-of-body (the connection closure signals the end
// of the response per HTTP/1.1 when there is no Content-Length).
// We must check this before endTransfer, which may reset the
// easy handle.
const is_conn_close_recv = blk: {
const err = msg.err orelse break :blk false;
if (err != error.RecvError) break :blk false;
const hdr = msg.conn.getResponseHeader("connection", 0) orelse break :blk false;
break :blk std.ascii.eqlIgnoreCase(hdr.value, "close");
};
// release it ASAP so that it's available; some done_callbacks // release it ASAP so that it's available; some done_callbacks
// will load more resources. // will load more resources.
self.endTransfer(transfer); self.endTransfer(transfer);
defer transfer.deinit(); defer transfer.deinit();
if (msg.err) |err| { if (msg.err != null and !is_conn_close_recv) {
requestFailed(transfer, err, true); requestFailed(transfer, msg.err.?, true);
} else blk: { } else blk: {
// make sure the transfer can't be immediately aborted from a callback // make sure the transfer can't be immediately aborted from a callback
// since we still need it here. // since we still need it here.