public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 12:44:43 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Don't assume that a 'keydown' event is a KeyboardEvent

Browse Source
This commit is contained in:
Karl Seguin
2026-02-26 15:26:34 +08:00
parent 641c7b2c89
commit bad0fc386d
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/browser/Page.zig
View File

@@ -3069,7 +3069,7 @@ pub fn triggerKeyboard(self: *Page, keyboard_event: *KeyboardEvent) !void {
} }
pub fn handleKeydown(self: *Page, target: *Node, event: *Event) !void { pub fn handleKeydown(self: *Page, target: *Node, event: *Event) !void {
const keyboard_event = event.as(KeyboardEvent); const keyboard_event = event.is(KeyboardEvent) orelse return;
const key = keyboard_event.getKey(); const key = keyboard_event.getKey();
if (key == .Dead) { if (key == .Dead) {

13
src/browser/tests/event/keyboard.html
View File

@@ -103,3 +103,16 @@
document.dispatchEvent(new KeyboardEvent('keytest', {key: 'b'})); document.dispatchEvent(new KeyboardEvent('keytest', {key: 'b'}));
testing.expectEqual(false, keyIsTrusted); testing.expectEqual(false, keyIsTrusted);
</script> </script>
<script id=non_keyboard_keydown>
// this used to crash
{
let called = false;
const div = document.createElement('div')
div.addEventListener('keydown', () => {
called = true;
});
div.dispatchEvent(new Event('keydown'));
testing.expectEqual(true, called);
}
</script>