public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

server: REUSEPORT is not allowed on unix socket

Browse Source 
see 5b0af621c3
This commit is contained in:
Pierre Tachoire
2025-01-22 16:08:22 +01:00
parent 482ed8d958
commit bbdf63635a
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/server.zig
View File

@@ -498,19 +498,22 @@ fn isUnixSocket(addr: std.net.Address) bool {
} }
pub fn listen(address: std.net.Address) !std.posix.socket_t { pub fn listen(address: std.net.Address) !std.posix.socket_t {
const isunixsock = isUnixSocket(address);
// create socket // create socket
const flags = std.posix.SOCK.STREAM | std.posix.SOCK.CLOEXEC | std.posix.SOCK.NONBLOCK; const flags = std.posix.SOCK.STREAM | std.posix.SOCK.CLOEXEC | std.posix.SOCK.NONBLOCK;
const proto = if (isUnixSocket(address)) @as(u32, 0) else std.posix.IPPROTO.TCP; const proto = if (isunixsock) @as(u32, 0) else std.posix.IPPROTO.TCP;
const sockfd = try std.posix.socket(address.any.family, flags, proto); const sockfd = try std.posix.socket(address.any.family, flags, proto);
errdefer std.posix.close(sockfd); errdefer std.posix.close(sockfd);
// socket options // socket options
if (@hasDecl(std.posix.SO, "REUSEPORT")) { //
// REUSEPORT can't be set on unix socket anymore.
// see https://github.com/torvalds/linux/commit/5b0af621c3f6ef9261cf6067812f2fd9943acb4b
if (@hasDecl(std.posix.SO, "REUSEPORT") and !isunixsock) {
try setSockOpt(sockfd, std.posix.SOL.SOCKET, std.posix.SO.REUSEPORT, 1); try setSockOpt(sockfd, std.posix.SOL.SOCKET, std.posix.SO.REUSEPORT, 1);
} else {
try setSockOpt(sockfd, std.posix.SOL.SOCKET, std.posix.SO.REUSEADDR, 1);
} }
try setSockOpt(sockfd, std.posix.SOL.SOCKET, std.posix.SO.REUSEADDR, 1);
if (!isUnixSocket(address)) { if (!isUnixSocket(address)) {
if (builtin.target.os.tag == .linux) { // posix.TCP not available on MacOS if (builtin.target.os.tag == .linux) { // posix.TCP not available on MacOS
// WARNING: disable Nagle's alogrithm to avoid latency issues // WARNING: disable Nagle's alogrithm to avoid latency issues