public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1424 from lightpanda-io/parser_append_existing_parent

Browse Source 
Add defensiveness around Parser.appendCallback
This commit is contained in:
Karl Seguin
2026-01-28 09:21:14 +08:00
committed by GitHub
parent 068ec68917 30ed58ff07
commit bc700d2044
3 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/browser/parser/Parser.zig
View File

@@ -24,6 +24,7 @@ const Page = @import("../Page.zig");
const Node = @import("../webapi/Node.zig"); const Node = @import("../webapi/Node.zig");
const Element = @import("../webapi/Element.zig"); const Element = @import("../webapi/Element.zig");
const Allocator = std.mem.Allocator; const Allocator = std.mem.Allocator;
const IS_DEBUG = @import("builtin").mode == .Debug;
pub const ParsedNode = struct { pub const ParsedNode = struct {
node: *Node, node: *Node,
@@ -373,6 +374,17 @@ fn _appendCallback(self: *Parser, parent: *Node, node_or_text: h5e.NodeOrText) !
switch (node_or_text.toUnion()) { switch (node_or_text.toUnion()) {
.node => |cpn| { .node => |cpn| {
const child = getNode(cpn); const child = getNode(cpn);
if (child._parent) |previous_parent| {
// html5ever says this can't happen, but we might be screwing up
// the node on our side. We shouldn't be, but we're seeing this
// in the wild, and I'm not sure why. In debug, let's crash so
// we can try to figure it out. In release, let's disconnect
// the child first.
if (comptime IS_DEBUG) {
unreachable;
}
self.page.removeNode(previous_parent, child, .{ .will_be_reconnected = parent.isConnected() });
}
try self.page.appendNew(parent, .{ .node = child }); try self.page.appendNew(parent, .{ .node = child });
}, },
.text => |txt| try self.page.appendNew(parent, .{ .text = txt }), .text => |txt| try self.page.appendNew(parent, .{ .text = txt }),