public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #1020 from lightpanda-io/inline_script_ignore_defer
Some checks failed
e2e-test / zig build release (push) Has been cancelled
Details
zig-test / zig build dev (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
e2e-test / demo-scripts (push) Has been cancelled
Details
e2e-test / cdp-and-hyperfine-bench (push) Has been cancelled
Details
e2e-test / perf-fmt (push) Has been cancelled
Details
zig-test / browser fetch (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details
nightly build / build-linux-x86_64 (push) Has been cancelled
Details
nightly build / build-linux-aarch64 (push) Has been cancelled
Details
nightly build / build-macos-aarch64 (push) Has been cancelled
Details
nightly build / build-macos-x86_64 (push) Has been cancelled
Details
wpt / web platform tests json output (push) Has been cancelled
Details
wpt / perf-fmt (push) Has been cancelled
Details

Browse Source 
Inline script tags ignore defer/async
This commit is contained in:
Pierre Tachoire
2025-09-05 17:44:45 +02:00
committed by GitHub
parent d5363e5993 eb453f471b
commit bc82023878
4 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/browser/ScriptManager.zig
View File

@@ -170,8 +170,8 @@ pub fn addFromElement(self: *ScriptManager, element: *parser.Element) !void {
.element = element, .element = element,
.source = source, .source = source,
.url = remote_url orelse page.url.raw, .url = remote_url orelse page.url.raw,
.is_defer = try parser.elementGetAttribute(element, "defer") != null, .is_defer = if (remote_url == null) false else try parser.elementGetAttribute(element, "defer") != null,
.is_async = try parser.elementGetAttribute(element, "async") != null, .is_async = if (remote_url == null) false else try parser.elementGetAttribute(element, "async") != null,
}; };
if (source == .@"inline" and self.scripts.first == null) { if (source == .@"inline" and self.scripts.first == null) {

4
src/browser/html/elements.zig
View File

@@ -1480,6 +1480,10 @@ test "Browser.HTML.HTMLStyleElement" {
}, .{}); }, .{});
} }
test "Browser: HTML.HTMLScriptElement" {
try testing.htmlRunner("html/script/inline_defer.html");
}
const Check = struct { const Check = struct {
input: []const u8, input: []const u8,
expected: ?[]const u8 = null, // Needed when input != expected expected: ?[]const u8 = null, // Needed when input != expected

27
src/tests/html/script/inline_defer.html Normal file
View File

@@ -0,0 +1,27 @@
<head>
<script>
let dyn1_loaded = 0;
function loadScript(src) {
const script = document.createElement('script');
script.src = src;
document.getElementsByTagName("head")[0].appendChild(script)
}
</script>
</head>
<script src="../../testing.js"></script>
<script defer>
loadScript('inline_defer.js');
</script>
<script async>
loadScript('inline_defer.js');
</script>
<script id=inline_defer>
// inline script should ignore defer and async attributes. If we don't do
// this correctly, we'd end up in an infinite loop
// https://github.com/lightpanda-io/browser/issues/1014
testing.eventually(() => testing.expectEqual(2, dyn1_loaded));
</script>

1
src/tests/html/script/inline_defer.js Normal file
View File

@@ -0,0 +1 @@
dyn1_loaded += 1;