public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

node: don't call owner twice in _insertBefore

Browse Source 
When the ref_node_ is null, call directly _appendChild w/o fixing the
node's owner.
This commit is contained in:
Pierre Tachoire
2025-08-05 14:45:25 +02:00
parent 0a5f060d1b
commit bd9e4dbc79
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/browser/dom/node.zig
View File

@@ -307,27 +307,28 @@ pub const Node = struct {
} }
pub fn _insertBefore(self: *parser.Node, new_node: *parser.Node, ref_node_: ?*parser.Node) !Union { pub fn _insertBefore(self: *parser.Node, new_node: *parser.Node, ref_node_: ?*parser.Node) !Union {
if (ref_node_ == null) {
return _appendChild(self, new_node);
}
const self_owner = try parser.nodeOwnerDocument(self); const self_owner = try parser.nodeOwnerDocument(self);
const new_node_owner = try parser.nodeOwnerDocument(new_node); const new_node_owner = try parser.nodeOwnerDocument(new_node);
// If the node to be inserted has a different ownerDocument than the parent node, // If the node to be inserted has a different ownerDocument than the parent node,
// modern browsers automatically adopt the node and its descendants into // modern browsers automatically adopt the node and its descendants into
// the parent's ownerDocument. // the parent's ownerDocument.
// This process is known as adoption. // This process is known as adoption.
// (7.1) https://dom.spec.whatwg.org/#concept-node-insert // (7.1) https://dom.spec.whatwg.org/#concept-node-insert
if (new_node_owner == null or (new_node_owner.? != self_owner.?)) { if (new_node_owner == null or (new_node_owner.? != self_owner.?)) {
const w = Walker{}; const w = Walker{};
var current = new_node; var current = new_node;
while(true) { while (true) {
current.owner = self_owner; current.owner = self_owner;
current = try w.get_next(new_node, current) orelse break; current = try w.get_next(new_node, current) orelse break;
} }
} }
if (ref_node_) |ref_node| { return Node.toInterface(try parser.nodeInsertBefore(self, new_node, ref_node_.?));
return Node.toInterface(try parser.nodeInsertBefore(self, new_node, ref_node));
}
return _appendChild(self, new_node);
} }
pub fn _isDefaultNamespace(self: *parser.Node, namespace: ?[]const u8) !bool { pub fn _isDefaultNamespace(self: *parser.Node, namespace: ?[]const u8) !bool {