public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1393 from lightpanda-io/remove_js_obj_cache

Browse Source 
Disable JS object cache
This commit is contained in:
Pierre Tachoire
2026-01-21 08:14:24 +01:00
committed by GitHub
parent ff8ed24622 ae2d6a122b
commit c27ab35600
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/browser/js/Caller.zig
View File

@@ -160,18 +160,6 @@ fn _method(self: *Caller, comptime T: type, func: anytype, info: FunctionCallbac
const mapped = try self.local.zigValueToJs(res, opts); const mapped = try self.local.zigValueToJs(res, opts);
const return_value = info.getReturnValue(); const return_value = info.getReturnValue();
return_value.set(mapped); return_value.set(mapped);
if (comptime opts.cache != null) {
// store the return value directly in the JS object for faster subsequent
// calls. We only do this for a few frequently used properties (e.g. window.document)
const local = self.local;
const key_handle = local.isolate.initStringHandle(opts.cache.?);
var out: v8.MaybeBool = undefined;
v8.v8__Object__DefineOwnProperty(js_this, local.handle, key_handle, mapped.handle, 0, &out);
if (comptime IS_DEBUG) {
std.debug.assert(out.has_value and out.value);
}
}
} }
pub fn function(self: *Caller, comptime T: type, func: anytype, handle: *const v8.FunctionCallbackInfo, comptime opts: CallOpts) void { pub fn function(self: *Caller, comptime T: type, func: anytype, handle: *const v8.FunctionCallbackInfo, comptime opts: CallOpts) void {