From c28afbf19309c10937a9984e95b131a9ae498a6b Mon Sep 17 00:00:00 2001
From: egrs <egrs@users.noreply.github.com>
Date: Wed, 18 Feb 2026 15:40:59 +0100
Subject: [PATCH] address review feedback: move stubs test, inline bridge
 functions, catch unreachable

---
 .../{window-stubs.html => window/stubs.html}  |  2 +-
 src/browser/webapi/Window.zig                 | 26 ++++++++++---------
 src/browser/webapi/element/Html.zig           |  2 +-
 3 files changed, 16 insertions(+), 14 deletions(-)
 rename src/browser/tests/{window-stubs.html => window/stubs.html} (95%)
diff --git a/src/browser/tests/window-stubs.html b/src/browser/tests/window/stubs.html
similarity index 95%
rename from src/browser/tests/window-stubs.html
rename to src/browser/tests/window/stubs.html
index 6b6f375b..74c8a944 100644
--- a/src/browser/tests/window-stubs.html
+++ b/src/browser/tests/window/stubs.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<script src="testing.js"></script>
+<script src="../testing.js"></script>
 
 <script id="alert">
   {
diff --git a/src/browser/webapi/Window.zig b/src/browser/webapi/Window.zig
index 898ba71e..e90bf4b0 100644
--- a/src/browser/webapi/Window.zig
+++ b/src/browser/webapi/Window.zig
@@ -704,14 +704,6 @@ fn getFunctionFromSetter(setter_: ?FunctionSetter) ?js.Function.Global {
     };
 }
 
-// Headless browser stubs: alert/confirm/prompt are no-ops
-fn jsAlert(_: *Window, _: ?[]const u8) void {}
-fn jsConfirm(_: *Window, _: ?[]const u8) bool {
-    return false;
-}
-fn jsPrompt(_: *Window, _: ?[]const u8, _: ?[]const u8) ?[]const u8 {
-    return null;
-}
 
 pub const JsApi = struct {
     pub const bridge = js.Bridge(Window);
@@ -790,13 +782,23 @@ pub const JsApi = struct {
     // pretty complicated to properly support I think.
     pub const opener = bridge.property(null, .{ .template = false });
 
-    pub const alert = bridge.function(Window.jsAlert, .{});
-    pub const confirm = bridge.function(Window.jsConfirm, .{});
-    pub const prompt = bridge.function(Window.jsPrompt, .{});
+    pub const alert = bridge.function(struct {
+        fn alert(_: *const Window, _: ?[]const u8) void {}
+    }.alert, .{});
+    pub const confirm = bridge.function(struct {
+        fn confirm(_: *const Window, _: ?[]const u8) bool {
+            return false;
+        }
+    }.confirm, .{});
+    pub const prompt = bridge.function(struct {
+        fn prompt(_: *const Window, _: ?[]const u8, _: ?[]const u8) ?[]const u8 {
+            return null;
+        }
+    }.prompt, .{});
 };
 
 const testing = @import("../../testing.zig");
 test "WebApi: Window" {
     try testing.htmlRunner("window", .{});
-    try testing.htmlRunner("window-stubs.html", .{});
+    try testing.htmlRunner("window/stubs.html", .{});
 }
diff --git a/src/browser/webapi/element/Html.zig b/src/browser/webapi/element/Html.zig
index ba6361d3..5f2cb867 100644
--- a/src/browser/webapi/element/Html.zig
+++ b/src/browser/webapi/element/Html.zig
@@ -369,7 +369,7 @@ pub fn getTabIndex(self: *HtmlElement) i32 {
 
 pub fn setTabIndex(self: *HtmlElement, value: i32, page: *Page) !void {
     var buf: [12]u8 = undefined;
-    const str = std.fmt.bufPrint(&buf, "{d}", .{value}) catch return;
+    const str = std.fmt.bufPrint(&buf, "{d}", .{value}) catch unreachable;
     try self.asElement().setAttributeSafe(comptime .wrap("tabindex"), .wrap(str), page);
 }
 
