public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #923 from lightpanda-io/doc-owner-next
Some checks failed
e2e-test / zig build release (push) Has been cancelled
Details
e2e-test / demo-scripts (push) Has been cancelled
Details
e2e-test / cdp-and-hyperfine-bench (push) Has been cancelled
Details
e2e-test / perf-fmt (push) Has been cancelled
Details
zig-test / zig build dev (push) Has been cancelled
Details
zig-test / browser fetch (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details
nightly build / build-linux-x86_64 (push) Has been cancelled
Details
nightly build / build-linux-aarch64 (push) Has been cancelled
Details
nightly build / build-macos-aarch64 (push) Has been cancelled
Details
nightly build / build-macos-x86_64 (push) Has been cancelled
Details
wpt / web platform tests json output (push) Has been cancelled
Details
wpt / perf-fmt (push) Has been cancelled
Details

Browse Source 
node: don't call owner twice in _insertBefore
This commit is contained in:
Pierre Tachoire
2025-08-05 15:59:16 +02:00
committed by GitHub
parent 0c19070800 b2b2e97edc
commit c453dd2b3c
1 changed files with 27 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/browser/dom/node.zig
View File

@@ -307,6 +307,10 @@ pub const Node = struct {
} }
pub fn _insertBefore(self: *parser.Node, new_node: *parser.Node, ref_node_: ?*parser.Node) !Union { pub fn _insertBefore(self: *parser.Node, new_node: *parser.Node, ref_node_: ?*parser.Node) !Union {
if (ref_node_ == null) {
return _appendChild(self, new_node);
}
const self_owner = try parser.nodeOwnerDocument(self); const self_owner = try parser.nodeOwnerDocument(self);
const new_node_owner = try parser.nodeOwnerDocument(new_node); const new_node_owner = try parser.nodeOwnerDocument(new_node);
@@ -324,10 +328,7 @@ pub const Node = struct {
} }
} }
if (ref_node_) |ref_node| { return Node.toInterface(try parser.nodeInsertBefore(self, new_node, ref_node_.?));
return Node.toInterface(try parser.nodeInsertBefore(self, new_node, ref_node));
}
return _appendChild(self, new_node);
} }
pub fn _isDefaultNamespace(self: *parser.Node, namespace: ?[]const u8) !bool { pub fn _isDefaultNamespace(self: *parser.Node, namespace: ?[]const u8) !bool {
@@ -770,12 +771,9 @@ test "Browser.DOM.node.owner" {
.{ .{
\\ const parser = new DOMParser(); \\ const parser = new DOMParser();
\\ const newDoc = parser.parseFromString('<div id="new-node"><p>Hey</p><span>Marked</span></div>', 'text/html'); \\ const newDoc = parser.parseFromString('<div id="new-node"><p>Hey</p><span>Marked</span></div>', 'text/html');
\\ const newNode = newDoc.getElementById('new-node'); \\ const newNode = newDoc.getElementById('new-node');
\\ const parent = document.getElementById('target-container'); \\ const parent = document.getElementById('target-container');
\\ const referenceNode = document.getElementById('reference-node'); \\ const referenceNode = document.getElementById('reference-node');
\\ parent.insertBefore(newNode, referenceNode); \\ parent.insertBefore(newNode, referenceNode);
\\ const k = document.getElementById('new-node'); \\ const k = document.getElementById('new-node');
\\ const ptag = k.querySelector('p'); \\ const ptag = k.querySelector('p');