public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-28 15:40:04 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Address review: use arena.dupeZ for URL copy, add try to testing.context()

Browse Source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Navid EMAD
2026-03-26 10:08:42 +01:00
parent 93485c1ef3
commit c6b0c75106
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/cdp/domains/page.zig
View File

@@ -269,12 +269,8 @@ fn doReload(cmd: anytype) !void {
const session = bc.session; const session = bc.session;
var page = session.currentPage() orelse return error.PageNotLoaded; var page = session.currentPage() orelse return error.PageNotLoaded;
// Copy URL to stack before replacePage() frees the old page's arena. // Dupe URL before replacePage() frees the old page's arena.
var url_buf: [8192:0]u8 = undefined; const reload_url = try cmd.arena.dupeZ(u8, page.url);
const len = @min(page.url.len, url_buf.len);
@memcpy(url_buf[0..len], page.url[0..len]);
url_buf[len] = 0;
const reload_url: [:0]const u8 = url_buf[0..len :0];
if (page._load_state != .waiting) { if (page._load_state != .waiting) {
page = try session.replacePage(); page = try session.replacePage();
@@ -822,7 +818,7 @@ test "cdp.page: getLayoutMetrics" {
} }
test "cdp.page: reload" { test "cdp.page: reload" {
var ctx = testing.context(); var ctx = try testing.context();
defer ctx.deinit(); defer ctx.deinit();
{ {