public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-04-01 18:06:46 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

HTMLAllCollection

Browse Source
This commit is contained in:
Karl Seguin
2025-10-30 11:30:06 +08:00
parent 5ae1190ddd
commit c966211481
6 changed files with 284 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/browser/js/Env.zig
View File

@@ -279,6 +279,12 @@ pub fn attachClass(comptime JsApi: type, isolate: v8.Isolate, template: v8.Funct
else => {},
}
}
if (@hasDecl(JsApi.Meta, "htmldda")) {
const instance_template = template.getInstanceTemplate();
instance_template.markAsUndetectable();
instance_template.setCallAsFunctionHandler(JsApi.Meta.callable.func);
}
}
// Even if a struct doesn't have a `constructor` function, we still
@@ -315,28 +321,15 @@ fn generateConstructor(comptime JsApi: type, isolate: v8.Isolate) v8.FunctionTem
return template;
}
// ZIGDOM (HTMLAllCollection I think)
// fn generateUndetectable(comptime Struct: type, template: v8.ObjectTemplate) void {
// const has_js_call_as_function = @hasDecl(Struct, "jsCallAsFunction");
// if (has_js_call_as_function) {
// template.setCallAsFunctionHandler(struct {
// fn callback(raw_info: ?*const v8.C_FunctionCallbackInfo) callconv(.c) void {
// const info = v8.FunctionCallbackInfo.initFromV8(raw_info);
// var caller = Caller.init(info);
// defer caller.deinit();
// const named_function = comptime NamedFunction.init(Struct, "jsCallAsFunction");
// caller.method(Struct, named_function, info) catch |err| {
// caller.handleError(Struct, named_function, err, info);
// };
// }
// }.callback);
// }
// if (@hasDecl(Struct, "mark_as_undetectable") and Struct.mark_as_undetectable) {
// if (@hasDecl(Struct, "htmldda") and Struct.htmldda) {
// if (!has_js_call_as_function) {
// @compileError(@typeName(Struct) ++ ": mark_as_undetectable required jsCallAsFunction to be defined. This is a hard-coded requirement in V8, because mark_as_undetectable only exists for HTMLAllCollection which is also callable.");
// @compileError(@typeName(Struct) ++ ": htmldda required jsCallAsFunction to be defined. This is a hard-coded requirement in V8, because mark_as_undetectable only exists for HTMLAllCollection which is also callable.");
// }
// template.markAsUndetectable();
// }