public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #1188 from lightpanda-io/script-load-order
Some checks are pending
e2e-test / zig build release (push) Waiting to run
Details
e2e-test / demo-scripts (push) Blocked by required conditions
Details
e2e-test / cdp-and-hyperfine-bench (push) Blocked by required conditions
Details
e2e-test / perf-fmt (push) Blocked by required conditions
Details
zig-test / zig build dev (push) Waiting to run
Details
zig-test / browser fetch (push) Blocked by required conditions
Details
zig-test / zig test (push) Waiting to run
Details
zig-test / perf-fmt (push) Blocked by required conditions
Details

Browse Source 
add a test for script load order
This commit is contained in:
Pierre Tachoire
2025-10-28 14:12:31 +01:00
committed by GitHub
parent 07e603ecda 706a87a458
commit cc83d85542
6 changed files with 55 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/browser/ScriptManager.zig
View File

@@ -643,6 +643,18 @@ pub const PendingScript = struct {
// if async isn't known, it'll fallback to defer. // if async isn't known, it'll fallback to defer.
const script = &self.script; const script = &self.script;
// Module scripts are deferred by default.
// https://v8.dev/features/modules#defer
if (script.kind == .module) {
return &self.manager.deferreds;
}
// Script is not a module but inline, we ignore async/defer properties.
if (script.source == .@"inline") {
return &self.manager.scripts;
}
if (script.is_async) { if (script.is_async) {
return &self.manager.asyncs; return &self.manager.asyncs;
} }
@@ -651,12 +663,6 @@ pub const PendingScript = struct {
return &self.manager.deferreds; return &self.manager.deferreds;
} }
// Module scripts are deferred by default.
// https://v8.dev/features/modules#defer
if (script.kind == .module) {
return &self.manager.deferreds;
}
return &self.manager.scripts; return &self.manager.scripts;
} }
}; };

1
src/browser/html/elements.zig
View File

@@ -1350,6 +1350,7 @@ test "Browser: HTML.HtmlScriptElement" {
try testing.htmlRunner("html/script/import.html"); try testing.htmlRunner("html/script/import.html");
try testing.htmlRunner("html/script/dynamic_import.html"); try testing.htmlRunner("html/script/dynamic_import.html");
try testing.htmlRunner("html/script/importmap.html"); try testing.htmlRunner("html/script/importmap.html");
try testing.htmlRunner("html/script/order.html");
} }
test "Browser: HTML.HtmlSlotElement" { test "Browser: HTML.HtmlSlotElement" {

35
src/tests/html/script/order.html Normal file
View File

@@ -0,0 +1,35 @@
<!DOCTYPE html>
<script src="../../testing.js"></script>
<script defer id="remote_defer" src="order_defer.js"></script>
<script defer id="remote_async" src="order_async.js"></script>
<script type=module id="inline_module">
// inline module is always deferred.
list += 'g';
testing.expectEqual('abcdefg', list);
</script>
<script>
var list = '';
</script>
<script id="remote" src="order.js"></script>
<script async id="inline_async">
// inline script ignore async
list += 'b';
testing.expectEqual('ab', list);
</script>
<script defer id="inline_defer">
// inline script ignore defer
list += 'c';
testing.expectEqual('abc', list);
</script>
<script id="default">
// simple inline script
list += 'd';
testing.expectEqual('abcd', list);
</script>

2
src/tests/html/script/order.js Normal file
View File

@@ -0,0 +1,2 @@
list += 'a';
testing.expectEqual('a', list);

3
src/tests/html/script/order_async.js Normal file
View File

@@ -0,0 +1,3 @@
list += 'f';
testing.expectEqual('abcdef', list);

2
src/tests/html/script/order_defer.js Normal file
View File

@@ -0,0 +1,2 @@
list += 'e';
testing.expectEqual('abcde', list);