public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-12-16 16:28:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Add DOMError check in DOMImplementation

Browse Source 
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
This commit is contained in:
Francis Bouvier
2023-11-29 15:15:11 +01:00
parent 2065d47d8e
commit ce913219a9
5 changed files with 34 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/dom/document.zig
View File

@@ -22,8 +22,8 @@ pub const Document = struct {
pub const prototype = *Node;
pub const mem_guarantied = true;
pub fn constructor() *parser.Document {
return parser.domImplementationCreateHTMLDocument(null);
pub fn constructor() !*parser.Document {
return try parser.domImplementationCreateHTMLDocument(null);
}
// JS funcs

8
src/dom/exceptions.zig
View File

@@ -54,7 +54,11 @@ pub const DOMException = struct {
.{ errName, callerName },
),
error.NoError => unreachable,
else => "", // TODO: implement other messages
else => try allocPrint(
alloc,
"{s}: TODO message", // TODO: implement other messages
.{DOMException.name(errCast)},
),
};
return .{ .err = errCast, .str = str };
}
@@ -154,6 +158,8 @@ pub fn testExecFn(
.{ .src = "HierarchyRequestError.code", .ex = "3" },
.{ .src = "HierarchyRequestError.message", .ex = err },
.{ .src = "HierarchyRequestError.toString()", .ex = "HierarchyRequestError: " ++ err },
.{ .src = "HierarchyRequestError instanceof DOMException", .ex = "true" },
.{ .src = "HierarchyRequestError instanceof Error", .ex = "true" },
};
try checkCases(js_env, &cases);
}

11
src/dom/implementation.zig
View File

@@ -8,11 +8,14 @@ const checkCases = jsruntime.test_utils.checkCases;
const Document = @import("document.zig").Document;
const DocumentType = @import("document_type.zig").DocumentType;
const DOMException = @import("exceptions.zig").DOMException;
// WEB IDL https://dom.spec.whatwg.org/#domimplementation
pub const DOMImplementation = struct {
pub const mem_guarantied = true;
pub const Exception = DOMException;
pub fn _createDocumentType(
_: *DOMImplementation,
alloc: std.mem.Allocator,
@@ -29,7 +32,7 @@ pub const DOMImplementation = struct {
const csystemId = try alloc.dupeZ(u8, systemId);
defer alloc.free(csystemId);
return parser.domImplementationCreateDocumentType(cqname, cpublicId, csystemId);
return try parser.domImplementationCreateDocumentType(cqname, cpublicId, csystemId);
}
pub fn _createDocument(
@@ -51,11 +54,11 @@ pub const DOMImplementation = struct {
defer alloc.free(cqname.?);
}
return parser.domImplementationCreateDocument(cnamespace, cqname, doctype);
return try parser.domImplementationCreateDocument(cnamespace, cqname, doctype);
}
pub fn _createHTMLDocument(_: *DOMImplementation, title: ?[]const u8) *parser.Document {
return parser.domImplementationCreateHTMLDocument(title);
pub fn _createHTMLDocument(_: *DOMImplementation, title: ?[]const u8) !*parser.Document {
return try parser.domImplementationCreateHTMLDocument(title);
}
pub fn _hasFeature(_: *DOMImplementation) bool {