public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 06:23:45 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1462 from lightpanda-io/check_for_leaks_after_all_releases

Browse Source 
Only check for arena leaks AFTER we've triggered all releases
This commit is contained in:
Karl Seguin
2026-02-03 18:43:40 +08:00
committed by GitHub
parent 8d51383fb2 2fa7810128
commit d46a9d6286
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/browser/Page.zig
View File

@@ -277,22 +277,24 @@ fn reset(self: *Page, comptime initializing: bool) !void {
browser.env.destroyContext(self.js); browser.env.destroyContext(self.js);
// removing a context can trigger finalizers, so we can only check for
// a leak after the above.
if (comptime IS_DEBUG) {
var it = self._arena_pool_leak_track.valueIterator();
while (it.next()) |value_ptr| {
log.err(.bug, "ArenaPool Leak", .{ .owner = value_ptr.* });
}
self._arena_pool_leak_track.clearRetainingCapacity();
}
// We force a garbage collection between page navigations to keep v8 // We force a garbage collection between page navigations to keep v8
// memory usage as low as possible. // memory usage as low as possible.
browser.env.memoryPressureNotification(.moderate); browser.env.memoryPressureNotification(.moderate);
self._script_manager.shutdown = true; self._script_manager.shutdown = true;
browser.http_client.abort(); browser.http_client.abort();
self._script_manager.deinit(); self._script_manager.deinit();
// destroying the context, and aborting the http_client can both cause
// resources to be freed. We need to check for a leak after we've finished
// all of our cleanup.
if (comptime IS_DEBUG) {
var it = self._arena_pool_leak_track.valueIterator();
while (it.next()) |value_ptr| {
log.err(.bug, "ArenaPool Leak", .{ .owner = value_ptr.* });
}
self._arena_pool_leak_track = .empty;
}
_ = browser.page_arena.reset(.{ .retain_with_limit = 1 * 1024 * 1024 }); _ = browser.page_arena.reset(.{ .retain_with_limit = 1 * 1024 * 1024 });
} }