public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-28 14:43:28 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

prefer call_arena in web APIs

Browse Source
This commit is contained in:
Halil Durak
2025-10-22 11:42:16 +03:00
parent 7d39bc979f
commit d4d35670a0
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/browser/html/elements.zig
View File

@@ -284,7 +284,7 @@ pub const HTMLAnchorElement = struct {
var u = try url(self, page); var u = try url(self, page);
defer u.destructor(); defer u.destructor();
return page.arena.dupe(u8, u.get_protocol()); return page.call_arena.dupe(u8, u.get_protocol());
} }
pub fn set_protocol(self: *parser.Anchor, protocol: []const u8, page: *Page) !void { pub fn set_protocol(self: *parser.Anchor, protocol: []const u8, page: *Page) !void {
@@ -301,7 +301,7 @@ pub const HTMLAnchorElement = struct {
var u = url(self, page) catch return ""; var u = url(self, page) catch return "";
defer u.destructor(); defer u.destructor();
return page.arena.dupe(u8, u.get_host()); return page.call_arena.dupe(u8, u.get_host());
} }
pub fn set_host(self: *parser.Anchor, host: []const u8, page: *Page) !void { pub fn set_host(self: *parser.Anchor, host: []const u8, page: *Page) !void {
@@ -316,7 +316,7 @@ pub const HTMLAnchorElement = struct {
pub fn get_hostname(self: *parser.Anchor, page: *Page) ![]const u8 { pub fn get_hostname(self: *parser.Anchor, page: *Page) ![]const u8 {
var u = url(self, page) catch return ""; var u = url(self, page) catch return "";
defer u.destructor(); defer u.destructor();
return page.arena.dupe(u8, u.get_hostname()); return page.call_arena.dupe(u8, u.get_hostname());
} }
pub fn set_hostname(self: *parser.Anchor, hostname: []const u8, page: *Page) !void { pub fn set_hostname(self: *parser.Anchor, hostname: []const u8, page: *Page) !void {
@@ -332,7 +332,7 @@ pub const HTMLAnchorElement = struct {
pub fn get_port(self: *parser.Anchor, page: *Page) ![]const u8 { pub fn get_port(self: *parser.Anchor, page: *Page) ![]const u8 {
var u = url(self, page) catch return ""; var u = url(self, page) catch return "";
defer u.destructor(); defer u.destructor();
return page.arena.dupe(u8, u.get_port()); return page.call_arena.dupe(u8, u.get_port());
} }
pub fn set_port(self: *parser.Anchor, maybe_port: ?[]const u8, page: *Page) !void { pub fn set_port(self: *parser.Anchor, maybe_port: ?[]const u8, page: *Page) !void {
@@ -359,7 +359,7 @@ pub const HTMLAnchorElement = struct {
return ""; return "";
} }
return page.arena.dupe(u8, username); return page.call_arena.dupe(u8, username);
} }
pub fn set_username(self: *parser.Anchor, maybe_username: ?[]const u8, page: *Page) !void { pub fn set_username(self: *parser.Anchor, maybe_username: ?[]const u8, page: *Page) !void {
@@ -378,7 +378,7 @@ pub const HTMLAnchorElement = struct {
var u = url(self, page) catch return ""; var u = url(self, page) catch return "";
defer u.destructor(); defer u.destructor();
return page.arena.dupe(u8, u.get_password()); return page.call_arena.dupe(u8, u.get_password());
} }
pub fn set_password(self: *parser.Anchor, maybe_password: ?[]const u8, page: *Page) !void { pub fn set_password(self: *parser.Anchor, maybe_password: ?[]const u8, page: *Page) !void {
@@ -397,7 +397,7 @@ pub const HTMLAnchorElement = struct {
var u = url(self, page) catch return ""; var u = url(self, page) catch return "";
defer u.destructor(); defer u.destructor();
return page.arena.dupe(u8, u.get_pathname()); return page.call_arena.dupe(u8, u.get_pathname());
} }
pub fn set_pathname(self: *parser.Anchor, pathname: []const u8, page: *Page) !void { pub fn set_pathname(self: *parser.Anchor, pathname: []const u8, page: *Page) !void {
@@ -431,7 +431,7 @@ pub const HTMLAnchorElement = struct {
var u = url(self, page) catch return ""; var u = url(self, page) catch return "";
defer u.destructor(); defer u.destructor();
return page.arena.dupe(u8, u.get_hash()); return page.call_arena.dupe(u8, u.get_hash());
} }
pub fn set_hash(self: *parser.Anchor, maybe_hash: ?[]const u8, page: *Page) !void { pub fn set_hash(self: *parser.Anchor, maybe_hash: ?[]const u8, page: *Page) !void {

3
src/browser/url/url.zig
View File

@@ -144,7 +144,6 @@ pub const URL = struct {
} }
pub fn get_origin(self: *const URL, page: *Page) ![]const u8 { pub fn get_origin(self: *const URL, page: *Page) ![]const u8 {
const arena = page.arena;
// `ada.getOriginNullable` allocates memory in order to find the `origin`. // `ada.getOriginNullable` allocates memory in order to find the `origin`.
// We'd like to use our arena allocator for such case; // We'd like to use our arena allocator for such case;
// so here we allocate the `origin` in page arena and free the original. // so here we allocate the `origin` in page arena and free the original.
@@ -155,7 +154,7 @@ pub const URL = struct {
defer ada.freeOwnedString(maybe_origin); defer ada.freeOwnedString(maybe_origin);
const origin = maybe_origin.data[0..maybe_origin.length]; const origin = maybe_origin.data[0..maybe_origin.length];
return arena.dupe(u8, origin); return page.call_arena.dupe(u8, origin);
} }
pub fn get_href(self: *const URL, page: *Page) ![]const u8 { pub fn get_href(self: *const URL, page: *Page) ![]const u8 {