public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #1007 from lightpanda-io/timeout_limit
Some checks failed
e2e-test / zig build release (push) Has been cancelled
Details
e2e-test / demo-scripts (push) Has been cancelled
Details
e2e-test / cdp-and-hyperfine-bench (push) Has been cancelled
Details
e2e-test / perf-fmt (push) Has been cancelled
Details
zig-test / zig build dev (push) Has been cancelled
Details
zig-test / browser fetch (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details

Browse Source 
Limit serve timeout to 1 week
This commit is contained in:
Karl Seguin
2025-09-04 16:02:39 +08:00
committed by GitHub
parent 7c6870f8eb da128f5d49
commit d81377b10d
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/main.zig
View File

@@ -137,7 +137,9 @@ fn run(alloc: Allocator) !void {
const server = &_server.?; const server = &_server.?;
defer server.deinit(); defer server.deinit();
server.run(address, opts.timeout * 1000) catch |err| { // max timeout of 1 week.
const timeout = if (opts.timeout > 604_800) 604_800_000 else @as(i32, opts.timeout) * 1000;
server.run(address, timeout) catch |err| {
log.fatal(.app, "server run error", .{ .err = err }); log.fatal(.app, "server run error", .{ .err = err });
return err; return err;
}; };
@@ -268,7 +270,7 @@ const Command = struct {
const Serve = struct { const Serve = struct {
host: []const u8, host: []const u8,
port: u16, port: u16,
timeout: u16, timeout: u31,
common: Common, common: Common,
}; };
@@ -369,7 +371,7 @@ const Command = struct {
\\ Defaults to 9222 \\ Defaults to 9222
\\ \\
\\--timeout Inactivity timeout in seconds before disconnecting clients \\--timeout Inactivity timeout in seconds before disconnecting clients
\\ Defaults to 10 (seconds) \\ Defaults to 10 (seconds). Limited to 604800 (1 week).
\\ \\
++ common_options ++ ++ common_options ++
\\ \\
@@ -465,7 +467,7 @@ fn parseServeArgs(
) !Command.Serve { ) !Command.Serve {
var host: []const u8 = "127.0.0.1"; var host: []const u8 = "127.0.0.1";
var port: u16 = 9222; var port: u16 = 9222;
var timeout: u16 = 10; var timeout: u31 = 10;
var common: Command.Common = .{}; var common: Command.Common = .{};
while (args.next()) |opt| { while (args.next()) |opt| {
@@ -497,7 +499,7 @@ fn parseServeArgs(
return error.InvalidArgument; return error.InvalidArgument;
}; };
timeout = std.fmt.parseInt(u16, str, 10) catch |err| { timeout = std.fmt.parseInt(u31, str, 10) catch |err| {
log.fatal(.app, "invalid argument value", .{ .arg = "--timeout", .err = err }); log.fatal(.app, "invalid argument value", .{ .arg = "--timeout", .err = err });
return error.InvalidArgument; return error.InvalidArgument;
}; };