public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

address review feedback

Browse Source 
- TreeWalker.Full instead of FullExcludeSelf so querying a specific
  nodeId evaluates the root element itself
- resolve href to absolute URL via URL.resolve
- isDisabled checks ancestor <fieldset disabled> with legend exemption
- parameter order: allocator before *Page per convention
This commit is contained in:
egrs
2026-03-10 08:13:01 +01:00
parent a417c73bf7
commit dc3958356d
2 changed files with 51 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cdp/domains/lp.zig
View File

@@ -71,7 +71,7 @@ fn getInteractiveElements(cmd: anytype) !void {
else
page.document.asNode();
const elements = try interactive.collectInteractiveElements(root, page, cmd.arena);
const elements = try interactive.collectInteractiveElements(root, cmd.arena, page);
// Register nodes so nodeIds are valid for subsequent CDP calls.
var node_ids: std.ArrayList(Node.Id) = try .initCapacity(cmd.arena, elements.len);