public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-04 14:33:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1292 from lightpanda-io/nikneym/script-execution-changes

Browse Source 
Run microtasks after each script execution
This commit is contained in:
Karl Seguin
2025-12-29 18:42:03 +08:00
committed by GitHub
parent 121cf40062 abc89b7eae
commit dcf1d34889
2 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/browser/Page.zig
View File

@@ -945,16 +945,6 @@ fn printWaitAnalysis(self: *Page) void {
} }
} }
pub fn tick(self: *Page) void {
if (comptime IS_DEBUG) {
log.debug(.page, "tick", .{});
}
_ = self.scheduler.run() catch |err| {
log.err(.page, "tick", .{ .err = err });
};
self.js.runMicrotasks();
}
pub fn isGoingAway(self: *const Page) bool { pub fn isGoingAway(self: *const Page) bool {
return self._queued_navigation != null; return self._queued_navigation != null;
} }

10
src/browser/ScriptManager.zig
View File

@@ -38,7 +38,7 @@ const ScriptManager = @This();
page: *Page, page: *Page,
// used to prevent recursive evalutaion // used to prevent recursive evaluation
is_evaluating: bool, is_evaluating: bool,
// Only once this is true can deferred scripts be run // Only once this is true can deferred scripts be run
@@ -803,7 +803,13 @@ pub const Script = struct {
log.debug(.browser, "executed script", .{ .src = url, .success = success, .on_load = script_element._on_load != null }); log.debug(.browser, "executed script", .{ .src = url, .success = success, .on_load = script_element._on_load != null });
} }
defer page.tick(); defer {
// We should run microtasks even if script execution fails.
page.js.runMicrotasks();
_ = page.scheduler.run() catch |err| {
log.err(.page, "scheduler", .{ .err = err });
};
}
if (success) { if (success) {
self.executeCallback("load", script_element._on_load, page); self.executeCallback("load", script_element._on_load, page);