public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #572 from lightpanda-io/framenavigated-order

Browse Source 
cdp: dispatch Page.frameNavigated before DOM.documentUpdated
This commit is contained in:
Karl Seguin
2025-04-25 08:47:07 +08:00
committed by GitHub
parent 332508f563 11c7f57745
commit dd8432e8fd
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/cdp/domains/page.zig
View File

@@ -243,8 +243,6 @@ pub fn pageNavigated(bc: anytype, event: *const Notification.PageNavigated) !voi
const target_id = bc.target_id orelse unreachable;
const session_id = bc.session_id orelse unreachable;
try cdp.sendEvent("DOM.documentUpdated", null, .{ .session_id = session_id });
// frameNavigated event
try cdp.sendEvent("Page.frameNavigated", .{
.type = "Navigation",
@@ -257,6 +255,11 @@ pub fn pageNavigated(bc: anytype, event: *const Notification.PageNavigated) !voi
},
}, .{ .session_id = session_id });
// The DOM.documentUpdated event must be send after the frameNavigated one.
// chromedp client expects to receive the events is this order.
// see https://github.com/chromedp/chromedp/issues/1558
try cdp.sendEvent("DOM.documentUpdated", null, .{ .session_id = session_id });
// domContentEventFired event
// TODO: partially hard coded
try cdp.sendEvent(