From ab31cc0a18f1f5a8ff12cd7b93d9d6a64e1de6f4 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Fri, 21 Jun 2024 15:18:28 +0200 Subject: [PATCH 1/2] wpt: if no test case found, the suite fails --- src/main_wpt.zig | 5 +++-- src/wpt/testcase.zig | 10 ++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/main_wpt.zig b/src/main_wpt.zig index 6dd63b2d..24e4b0fd 100644 --- a/src/main_wpt.zig +++ b/src/main_wpt.zig @@ -323,7 +323,7 @@ fn runSafe( if (c.pass) pass += 1; } } - const status = if (pass == all) "Pass" else "Fail"; + const status = if (all > 0 and pass == all) "Pass" else "Fail"; std.debug.print("{s} {d}/{d}", .{ status, pass, all }); continue; @@ -366,7 +366,8 @@ fn runSafe( if (c.pass) pass += 1; } } - std.debug.print("{d}/{d}\n\n", .{ pass, all }); + const status = if (all > 0 and pass == all) "Pass" else "Fail"; + std.debug.print("{s} {d}/{d}\n\n", .{ status, pass, all }); } if (out == .json) { diff --git a/src/wpt/testcase.zig b/src/wpt/testcase.zig index 5f7949eb..6c006e4a 100644 --- a/src/wpt/testcase.zig +++ b/src/wpt/testcase.zig @@ -137,6 +137,16 @@ pub const Suite = struct { try cases.append(case); } + if (cases.items.len == 0) { + // no test case, create a failed one. + suite.pass = false; + try cases.append(.{ + .pass = false, + .name = "no test case", + .message = "no test case", + }); + } + suite.cases = try cases.toOwnedSlice(); return suite; From 32015eae3c66cd38926cce4d6d893d9b05672fa2 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Fri, 21 Jun 2024 16:20:14 +0200 Subject: [PATCH 2/2] upgrade tests/wpt --- tests/wpt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/wpt b/tests/wpt index 702189f6..e0a721a3 160000 --- a/tests/wpt +++ b/tests/wpt @@ -1 +1 @@ -Subproject commit 702189f6d2f815bb01fe37d90bf134d488155f20 +Subproject commit e0a721a3b86050ddd9f4d671db12aee0a1939661