From e237e709b6c58b9b42b2bb15dd242f1c260a4885 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Tue, 2 Sep 2025 21:05:22 +0800 Subject: [PATCH] Change loader id on navigation This appears to be what chrome is doing. I don't know why we weren't before. --- src/cdp/cdp.zig | 1 - src/cdp/domains/page.zig | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/cdp/cdp.zig b/src/cdp/cdp.zig index a6b645d1..ae95e570 100644 --- a/src/cdp/cdp.zig +++ b/src/cdp/cdp.zig @@ -103,7 +103,6 @@ pub fn CDPT(comptime TypeProvider: type) type { pub fn handleMessage(self: *Self, msg: []const u8) bool { // if there's an error, it's already been logged self.processMessage(msg) catch return false; - // self.pageWait(); return true; } diff --git a/src/cdp/domains/page.zig b/src/cdp/domains/page.zig index 19ef1b77..1f7e4494 100644 --- a/src/cdp/domains/page.zig +++ b/src/cdp/domains/page.zig @@ -164,10 +164,7 @@ pub fn pageNavigate(arena: Allocator, bc: anytype, event: *const Notification.Pa var cdp = bc.cdp; - if (event.opts.reason != .address_bar) { - bc.loader_id = bc.cdp.loader_id_gen.next(); - } - + bc.loader_id = bc.cdp.loader_id_gen.next(); const loader_id = bc.loader_id; const target_id = bc.target_id orelse unreachable; const session_id = bc.session_id orelse unreachable;