From e4ae2df1a48304160ec2f951f1b2f0d03bbcb7ee Mon Sep 17 00:00:00 2001
From: Francis Bouvier <francis@lightpanda.io>
Date: Thu, 18 Apr 2024 11:57:39 +0200
Subject: [PATCH] Add some optional params in methods

Signed-off-by: Francis Bouvier <francis@lightpanda.io>
---
 src/cdp/emulation.zig | 19 +++++++++++++++++--
 src/cdp/page.zig      |  2 ++
 src/cdp/target.zig    |  8 +++++++-
 3 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/src/cdp/emulation.zig b/src/cdp/emulation.zig
index 1c8db4d0..ae759396 100644
--- a/src/cdp/emulation.zig
+++ b/src/cdp/emulation.zig
@@ -27,13 +27,28 @@ pub fn emulation(
     };
 }
 
+const MediaFeature = struct {
+    name: []const u8,
+    value: []const u8,
+};
+
 fn setEmulatedMedia(
     alloc: std.mem.Allocator,
     id: u64,
-    _: *std.json.Scanner,
+    scanner: *std.json.Scanner,
     _: *Ctx,
 ) ![]const u8 {
-    return result(alloc, id, null, null, null);
+    // input
+    const Params = struct {
+        media: ?[]const u8 = null,
+        features: ?[]MediaFeature = null,
+    };
+    _ = try getParams(alloc, Params, scanner);
+    const sessionID = try cdp.getSessionID(scanner);
+
+    // output
+    // TODO: dummy
+    return result(alloc, id, null, null, sessionID);
 }
 
 fn setFocusEmulationEnabled(
diff --git a/src/cdp/page.zig b/src/cdp/page.zig
index 9a47561e..a26fbe8a 100644
--- a/src/cdp/page.zig
+++ b/src/cdp/page.zig
@@ -104,6 +104,8 @@ fn addScriptToEvaluateOnNewDocument(
     const Params = struct {
         source: []const u8,
         worldName: ?[]const u8 = null,
+        includeCommandLineAPI: bool = false,
+        runImmediately: bool = false,
     };
     _ = try getParams(alloc, Params, scanner);
     const sessionID = try cdp.getSessionID(scanner);
diff --git a/src/cdp/target.zig b/src/cdp/target.zig
index 168be940..9b330025 100644
--- a/src/cdp/target.zig
+++ b/src/cdp/target.zig
@@ -31,6 +31,11 @@ const SessionID = "9559320D92474062597D9875C664CAC0";
 const TargetID = "CFCD6EC01573CF29BB638E9DC0F52DDC";
 const BrowserContextID = "65618675CB7D3585A95049E9DFE95EA9";
 
+const TargetFilter = struct {
+    type: []const u8,
+    exclude: bool,
+};
+
 fn tagetSetAutoAttach(
     alloc: std.mem.Allocator,
     id: u64,
@@ -40,7 +45,8 @@ fn tagetSetAutoAttach(
     const Params = struct {
         autoAttach: bool,
         waitForDebuggerOnStart: bool,
-        flatten: ?bool = null,
+        flatten: bool = true,
+        filter: ?[]TargetFilter = null,
     };
     const params = try getParams(alloc, Params, scanner);
     std.log.debug("params {any}", .{params});