public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-02-05 06:47:11 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

stop leaking robots_url when in robot queue

Browse Source
This commit is contained in:
Muki Kiboigo
2026-02-04 11:35:48 -08:00
parent 29ee7d41f5
commit e620c28a1c
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/http/Client.zig
View File

@@ -232,6 +232,7 @@ pub fn tick(self: *Client, timeout_ms: u32) !PerformStatus {
pub fn request(self: *Client, req: Request) !void { pub fn request(self: *Client, req: Request) !void {
if (self.config.obeyRobots()) { if (self.config.obeyRobots()) {
const robots_url = try URL.getRobotsUrl(self.allocator, req.url); const robots_url = try URL.getRobotsUrl(self.allocator, req.url);
errdefer self.allocator.free(robots_url);
// If we have this robots cached, we can take a fast path. // If we have this robots cached, we can take a fast path.
if (req.robots.get(robots_url)) |robot_entry| { if (req.robots.get(robots_url)) |robot_entry| {
@@ -334,6 +335,9 @@ fn fetchRobotsThenProcessRequest(self: *Client, robots_url: [:0]const u8, req: R
.done_callback = robotsDoneCallback, .done_callback = robotsDoneCallback,
.error_callback = robotsErrorCallback, .error_callback = robotsErrorCallback,
}); });
} else {
// Not using our own robots URL, only using the one from the first request.
self.allocator.free(robots_url);
} }
try entry.value_ptr.append(self.allocator, req); try entry.value_ptr.append(self.allocator, req);