public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Correctly JSON encode URL

Browse Source 
I think this code comes from some serialization tweak from when everything was
an std.Uri and by switch to [:0]const u8 everywhere not only was the tweak
unecessary, it was also wrong - possibly resulting in the generation of
invalid JSON.
This commit is contained in:
Karl Seguin
2026-02-28 12:48:45 +08:00
parent 516bd98198
commit e65667963f
1 changed files with 3 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/cdp/domains/network.zig
View File

@@ -300,29 +300,19 @@ pub const TransferAsRequestWriter = struct {
self._jsonStringify(jws) catch return error.WriteFailed; self._jsonStringify(jws) catch return error.WriteFailed;
} }
fn _jsonStringify(self: *const TransferAsRequestWriter, jws: anytype) !void { fn _jsonStringify(self: *const TransferAsRequestWriter, jws: anytype) !void {
const writer = jws.writer;
const transfer = self.transfer; const transfer = self.transfer;
try jws.beginObject(); try jws.beginObject();
{ {
try jws.objectField("url"); try jws.objectField("url");
try jws.beginWriteRaw(); try jws.write(transfer.url);
try writer.writeByte('\"');
// #ZIGDOM shouldn't include the hash?
try writer.writeAll(transfer.url);
try writer.writeByte('\"');
jws.endWriteRaw();
} }
{ {
const frag = URL.getHash(transfer.url); const frag = URL.getHash(transfer.url);
if (frag.len > 0) { if (frag.len > 0) {
try jws.objectField("urlFragment"); try jws.objectField("urlFragment");
try jws.beginWriteRaw(); try jws.write(frag);
try writer.writeAll("\"#");
try writer.writeAll(frag);
try writer.writeByte('\"');
jws.endWriteRaw();
} }
} }
@@ -366,18 +356,12 @@ const TransferAsResponseWriter = struct {
} }
fn _jsonStringify(self: *const TransferAsResponseWriter, jws: anytype) !void { fn _jsonStringify(self: *const TransferAsResponseWriter, jws: anytype) !void {
const writer = jws.writer;
const transfer = self.transfer; const transfer = self.transfer;
try jws.beginObject(); try jws.beginObject();
{ {
try jws.objectField("url"); try jws.objectField("url");
try jws.beginWriteRaw(); try jws.write(transfer.url);
try writer.writeByte('\"');
// #ZIGDOM shouldn't include the hash?
try writer.writeAll(transfer.url);
try writer.writeByte('\"');
jws.endWriteRaw();
} }
if (transfer.response_header) |*rh| { if (transfer.response_header) |*rh| {