public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1723 from lightpanda-io/cleanup-treewalker-helpers

Browse Source 
TreeWalker: remove unused methods
This commit is contained in:
Karl Seguin
2026-03-06 08:19:03 +08:00
committed by GitHub
parent e499d36126 320aaf0e33
commit e869df98c9
1 changed files with 22 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

101
src/browser/webapi/TreeWalker.zig
View File

@@ -51,67 +51,39 @@ pub fn TreeWalker(comptime mode: Mode) type {
self._current = node; self._current = node;
if (comptime mode == .children) { if (comptime mode == .children) {
self._next = Node.linkToNodeOrNull(node._child_link.next); self._next = node.nextSibling();
return node; return node;
} }
self._next = self.computeNextInDocumentOrder(node); if (node.firstChild()) |child| {
self._next = child;
} else {
var current: *Node = node;
while (current != self._root) {
if (current.nextSibling()) |sibling| {
self._next = sibling;
return node;
}
current = current._parent orelse break;
}
self._next = null;
}
return node; return node;
} }
pub fn skipChildren(self: *Self) void { pub fn skipChildren(self: *Self) void {
if (comptime mode == .children) return; if (comptime mode == .children) return;
const current = self._current orelse return; const current_node = self._current orelse return;
self._next = self.computeNextSiblingOrUncle(current);
}
pub fn nextSibling(self: *Self) ?*Node { var current: *Node = current_node;
const current = self._current orelse return null; while (current != self._root) {
const sibling = Node.linkToNodeOrNull(current._child_link.next) orelse return null; if (current.nextSibling()) |sibling| {
self._next = sibling;
self._current = sibling; return;
if (comptime mode == .children) {
self._next = Node.linkToNodeOrNull(sibling._child_link.next);
} else {
self._next = self.computeNextInDocumentOrder(sibling);
}
return sibling;
}
pub fn previousSibling(self: *Self) ?*Node {
const current = self._current orelse return null;
const sibling = Node.linkToNodeOrNull(current._child_link.prev) orelse return null;
self._current = sibling;
if (comptime mode == .children) {
self._next = Node.linkToNodeOrNull(sibling._child_link.next);
} else {
self._next = self.computeNextInDocumentOrder(sibling);
}
return sibling;
}
fn computeNextInDocumentOrder(self: *Self, node: *Node) ?*Node {
if (node._children) |children| {
return children.first();
}
return self.computeNextSiblingOrUncle(node);
}
fn computeNextSiblingOrUncle(self: *Self, node: *Node) ?*Node {
if (node._child_link.next) |n| {
return Node.linkToNode(n);
}
var current = node._parent;
while (current) |parent| {
if (parent == self._root) return null;
if (parent._child_link.next) |next_sibling| {
return Node.linkToNode(next_sibling);
} }
current = parent._parent; current = current._parent orelse break;
} }
return null; self._next = null;
} }
pub fn reset(self: *Self) void { pub fn reset(self: *Self) void {
@@ -220,32 +192,3 @@ test "TreeWalker: skipChildren" {
try testing.expect(tw.next() == null); try testing.expect(tw.next() == null);
} }
test "TreeWalker: sibling navigation" {
const testing = @import("../../testing.zig");
const page = try testing.test_session.createPage();
defer testing.test_session.removePage();
const doc = page.window._document;
// <div>
// <span>A</span>
// <p>B</p>
// </div>
const div = try doc.createElement("div", null, page);
const span = try doc.createElement("span", null, page);
const p = try doc.createElement("p", null, page);
_ = try div.asNode().appendChild(span.asNode(), page);
_ = try div.asNode().appendChild(p.asNode(), page);
var tw = Full.init(div.asNode(), .{});
// Move to span
_ = tw.next(); // div
_ = tw.next(); // span
// nextSibling -> p
try testing.expect(tw.nextSibling() == p.asNode());
// previousSibling -> span
try testing.expect(tw.previousSibling() == span.asNode());
}