Revert "Treat pending requests as active"

This reverts commit 19c908035b.
This commit is contained in:
Karl Seguin
2025-08-12 11:27:28 +08:00
parent 19c908035b
commit ea0bbaf332
2 changed files with 4 additions and 13 deletions

View File

@@ -185,14 +185,12 @@ pub fn tick(self: *Client, timeout_ms: usize) !void {
pub fn request(self: *Client, req: Request) !void { pub fn request(self: *Client, req: Request) !void {
if (self.handles.getFreeHandle()) |handle| { if (self.handles.getFreeHandle()) |handle| {
self.active += 1;
return self.makeRequest(handle, req); return self.makeRequest(handle, req);
} }
const node = try self.queue_node_pool.create(); const node = try self.queue_node_pool.create();
node.data = req; node.data = req;
self.queue.append(node); self.queue.append(node);
self.active += 1;
} }
// See ScriptManager.blockingGet // See ScriptManager.blockingGet
@@ -236,18 +234,13 @@ fn makeRequest(self: *Client, handle: *Handle, req: Request) !void {
// we need this for cookies // we need this for cookies
const uri = std.Uri.parse(req.url) catch |err| { const uri = std.Uri.parse(req.url) catch |err| {
self.active -= 1;
self.handles.release(handle); self.handles.release(handle);
log.warn(.http, "invalid url", .{ .err = err, .url = req.url }); log.warn(.http, "invalid url", .{ .err = err, .url = req.url });
return; return;
}; };
const header_list = blk: { const header_list = blk: {
errdefer { errdefer self.handles.release(handle);
self.active -= 1;
self.handles.release(handle);
}
try conn.setMethod(req.method); try conn.setMethod(req.method);
try conn.setURL(req.url); try conn.setURL(req.url);
@@ -282,10 +275,7 @@ fn makeRequest(self: *Client, handle: *Handle, req: Request) !void {
}; };
{ {
errdefer { errdefer self.handles.release(handle);
self.active -= 1;
self.handles.release(handle);
}
const transfer = try self.transfer_pool.create(); const transfer = try self.transfer_pool.create();
transfer.* = .{ transfer.* = .{
@@ -309,6 +299,7 @@ fn makeRequest(self: *Client, handle: *Handle, req: Request) !void {
} }
} }
self.active += 1;
return self.perform(0); return self.perform(0);
} }